Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix ipysheet column sort #22

Open
hndgzkn opened this issue Oct 23, 2020 · 1 comment · May be fixed by #24
Open

fix ipysheet column sort #22

hndgzkn opened this issue Oct 23, 2020 · 1 comment · May be fixed by #24

Comments

@hndgzkn
Copy link
Collaborator

hndgzkn commented Oct 23, 2020

When the data has too many rows, the interface uses pagination. If the user sorts using ipysheet column sort, the app only sorts the visible rows which might be misleading. Either we should sort all data, or disable sorting.

@hndgzkn
Copy link
Collaborator Author

hndgzkn commented Oct 26, 2020

ipysheet is built on Handsontable. While initializing, column sorting is enabled by default and ipysheet provides no parameter to disable that.

Made a pull request on ipysheet to enable/disable column sorting.

@hndgzkn hndgzkn linked a pull request Oct 26, 2020 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant