Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: make_trial_event_controller criteria for time columns allows "_time" to appear anywhere in column name #314

Open
2 tasks done
felixp8 opened this issue Oct 3, 2023 · 0 comments
Labels
bug Something isn't working

Comments

@felixp8
Copy link

felixp8 commented Oct 3, 2023

What happened?

The logic in make_trial_event_controller to determine trial event columns checks for "_time" in column_name, which is weaker than column_name.endswith("_time"), the check used by nwbinspector for example. Unsure what the consensus standard is here but in my case a boolean column called "has_timeout" was included as an alignment field, so I think the stronger check would be better.

Steps to Reproduce

n/a

Traceback

n/a

Operating System

Linux

Python Version

3.10

Package Versions

nwbinspector==0.11.3

Code of Conduct

@felixp8 felixp8 added the bug Something isn't working label Oct 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant