Review: Atlyss

[ButteredLilly]

Nexus Username

ButteredLilly

Extension URL

https://www.nexusmods.com/site/mods/1109

Game URL

https://www.nexusmods.com/atlyss

Existing Extension URL

No response

New features

No response

Information

• I confirm the above is accurate

Packaging

• This extension is packaged correctly

Testing

• This game extension has been tested

Review Tasks

If a task fails, contact the author to request changes before continuing.

• Double-check for existing extension
• Is the extension packaged correctly?
• Does it install into Vortex?
• Does it correctly discover the game?
• Does it successfully install a mod?
• Does it successfully install a collection?
• Does the game run correctly with the mods installed? ​

When reviewed and passed, please complete the following tasks:

• Run the GitHub Actions to add to manifest
• Contact author
• Ask Community to enable the Vortex button for the game
• Update the #vortex-announcements channel on Discord

[IDCs]

Hi there @ButteredLilly, first of all thank you for your contribution. Not sure you noticed, but there's a second extension attempting to add support for the same game:
https://www.nexusmods.com/site/mods/1110
#16736

Please discuss this with the author of the other extension and hopefully merge your efforts to provide your users with the best possible game support.

Both extensions have a flaw in the custom installer logic where you've set the FILE_EXT constant to an empty string, yet you're using it in the installer test to decide whether the installer is supported.

Additionally, you've provided support for MelonLoader which is great, but ideally you'd provide BepInEx support as well.
https://github.com/Nexus-Mods/Vortex/wiki/LEGACY-Tutorial-BepInEx-Extensions-Usage

Please have a read through existing BepInEx API documentation and implement support using the existing API.