Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Transitive dependency on pydantic < 2.0.0 due to snowflake==0.5.1 #95

Closed
3 of 4 tasks
maxim-mityutko opened this issue Feb 5, 2024 · 4 comments · Fixed by #102
Closed
3 of 4 tasks

[BUG] Transitive dependency on pydantic < 2.0.0 due to snowflake==0.5.1 #95

maxim-mityutko opened this issue Feb 5, 2024 · 4 comments · Fixed by #102
Labels
bug Something isn't working

Comments

@maxim-mityutko
Copy link
Contributor

maxim-mityutko commented Feb 5, 2024

Describe the bug
snowflake==0.5.1 has a transitive dependency on pydantic < 2.0.0. The snowflake dependency is always required if plugins functionality is enabled. Hence Brickflow usage is limited to the cases when no extra dependencies are required or if said dependencies does not require pydantic >= 2.0.0

To Reproduce
View snowflake package dependencies.

Expected behavior
Compatibility with pydantic >= 2.0.0

Screenshots

snowflake==0.5.1
├── snowflake-core [required: ==0.5.1, installed: 0.5.1]
│   ├── atpublic [required: >=4, installed: 4.0]
│   ├── pydantic [required: >=1.10.7,<2.0.0, installed: 1.10.13]
│   │   └── typing-extensions [required: >=4.2.0, installed: 4.9.0]

Cloud Information

  • AWS
  • Azure
  • GCP
  • Other

Desktop (please complete the following information):

  • OS: [e.g. iOS]
  • Browser [e.g. chrome, safari]
  • Version [e.g. 22]
@asingamaneni
Copy link
Collaborator

can I close this, as we will be working on this in #93 ?

@maxim-mityutko
Copy link
Contributor Author

I think so, it is mentioned in the other issue anyways. So the paper trail is there.

@maxim-mityutko
Copy link
Contributor Author

This can be resolved by:

  1. Bump snowflake dependency version to 0.6.0 in project dependencies.
  2. Bump the Airflow version to at least 2.7.3 in project dependencies.
  3. Update versions in:
    PypiTaskLibrary("apache-airflow==2.6.3"),
    PypiTaskLibrary("snowflake==0.5.1"),
    MavenTaskLibrary("com.cronutils:cron-utils:9.2.0"),

@asingamaneni
Copy link
Collaborator

@maxim-mityutko thanks for the solution, can you please raise the PR for the same and also update the pyproject.toml file!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants