Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Incorrect update of kwargs in Context class constructor #159

Closed
dannymeijer opened this issue Jan 28, 2025 · 0 comments · Fixed by #160
Closed

[BUG] Incorrect update of kwargs in Context class constructor #159

dannymeijer opened this issue Jan 28, 2025 · 0 comments · Fixed by #160
Assignees
Labels
bug Something isn't working
Milestone

Comments

@dannymeijer
Copy link
Member

Describe the bug

The __init__ method of the Context class incorrectly updates kwargs with the result of kwargs.update(arg.to_dict()), which returns None. This means that calls to Context containing another Context object, will fail.

Steps to Reproduce

  1. Go to 'context.py'
  2. Locate the __init__ method of the Context class
  3. Observe the line kwargs = kwargs.update(arg.to_dict())
  4. See the error

Expected behavior

The kwargs should be updated correctly without assigning the result of kwargs.update(arg.to_dict()) to kwargs.

@dannymeijer dannymeijer added the bug Something isn't working label Jan 28, 2025
@dannymeijer dannymeijer added this to the 0.10.0 milestone Jan 28, 2025
@dannymeijer dannymeijer self-assigned this Jan 28, 2025
@dannymeijer dannymeijer moved this to Todo in Koheesio Jan 28, 2025
@dannymeijer dannymeijer linked a pull request Jan 28, 2025 that will close this issue
9 tasks
@github-project-automation github-project-automation bot moved this from Todo to Done in Koheesio Jan 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

1 participant