Replaced BiometricPrompt with createConfirmDeviceCredentialIntent on Android 10+ and fallback mode enabled #425
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Whenever the **justAuthenticate** method is called with **isDeviceCredentialAllowed** and the [SDK level](https://apilevels.com/) is greater than **28**, **showAuthenticationScreen()** will be called directly instead of using the bugged Biometrics API. The result is exactly as intended. Perfectly fixes #417. Does not change current plugin behavior at all. Tested with Android 10 device.
|
@andreszs Why did you close this? |
|
This PR will become obsolete as soon as a new biometric API stable is released, and I'm working on a smaller plugin with authentication only. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Whenever the justAuthenticate method is called with isDeviceCredentialAllowed and the SDK level is greater than 28, showAuthenticationScreen() will be called directly instead of using the bugged Biometrics API. That method uses the legacy createConfirmDeviceCredentialIntent dialog which works exactly as intended.
Description
Perfectly fixes #417. Does not change current plugin behavior at all.
How did you test your changes?
Redmi 9 with Android 10.