Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use the correct zero value for time.Time throughout the codebase #54

Open
mihaitodor opened this issue Feb 3, 2020 · 0 comments
Open

Use the correct zero value for time.Time throughout the codebase #54

mihaitodor opened this issue Feb 3, 2020 · 0 comments

Comments

@mihaitodor
Copy link

The correct zero value for time.Time is time.Time{} instead of time.Unix(0, 0). Using the latter can cause hard to find bugs since func (Time) IsZero() would return false when called on time.Unix(0, 0). Details here: https://stackoverflow.com/questions/23051973/what-is-the-zero-value-for-time-time-in-go
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mihaitodor