Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mergebot mention in code review does not work #87

Open
bhankas opened this issue Apr 24, 2024 · 6 comments
Open

Mergebot mention in code review does not work #87

bhankas opened this issue Apr 24, 2024 · 6 comments

Comments

@bhankas
Copy link

bhankas commented Apr 24, 2024

If merge command is invoked as part of code review that approves the changes, mergebot does not get invoked. A separate, new independent comment is required. While that is fine, a code review with approval is a fairly strong signal. It'd be nice to have it supported.

@Mic92
Copy link
Member

Mic92 commented May 9, 2024

The main comment is fine but it shouldn't be part of the comments that one can hide.

@martinetd
Copy link
Member

Didn't work in main comment here:
NixOS/nixpkgs#313385

I thought it was because it wasn't the only line in the message, but the code seems to ignore unrelated lines just fine:

    for line in stripped.split("\n"):
        if re.match(rf"^@{bot_name}\s+merge$", line.strip()):
            return merge_command(issue, settings)

So I guess there really is a difference with review?

@Mic92
Copy link
Member

Mic92 commented Jun 7, 2024

I mean it's not implemented but if we implement, we should only accept the main comment of a review. Yes reviews are a different event in the api as far as I know.

@bhankas
Copy link
Author

bhankas commented Jun 7, 2024

@Mic92 main comment alone should be sufficient.

@sersorrel
Copy link

What would be required to implement this?

@Scriptkiddi
Copy link
Collaborator

This is because reviews are not comments for the GitHub API. To implement this I need a couple hours maybe some time next week I can get around to fixing this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants