Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Package request: llvmPackages_17 #257654

Closed
kuznetsss opened this issue Sep 27, 2023 · 8 comments · Fixed by #258614
Closed

Package request: llvmPackages_17 #257654

kuznetsss opened this issue Sep 27, 2023 · 8 comments · Fixed by #258614
Labels
0.kind: packaging request Request for a new package to be added 6.topic: llvm/clang Issues related to llvmPackages, clangStdenv and related

Comments

@kuznetsss
Copy link
Contributor

Project description
The LLVM Project is a collection of modular and reusable compiler and toolchain technologies.

Metadata

@kuznetsss kuznetsss added the 0.kind: packaging request Request for a new package to be added label Sep 27, 2023
@RaitoBezarius
Copy link
Member

Hi there, I don't think it will happen soon unfortunately as we still need to pick up the pieces of the last LLVM16/LLVM git divergences.

@RossComputerGuy
Copy link
Member

I've started some of the work to add LLVM 17, so far only llvmPackages_17.llvm builds but I have llvmPackages_17.clang compiling right this moment. I'll continue to work through getting the rest of the other llvm packages to build. I've opened a PR as a draft so it's easier to follow but once it's ready, I'll mark it ready for review. Anyone is free to comment or help out though.

@RaitoBezarius
Copy link
Member

@RossComputerGuy Please ensure that llvmPackages_git and llvmPackages_16 are sync with llvmPackages_17 if you do so. Each time, we give in to not stabilizing the divergences, we lose the opportunity to make it work for everything we learned about in the past release.

@RossComputerGuy
Copy link
Member

Alright, I'll keep that in mind. Didn't realize there was a llvm git package, I only copied the stuff from llvm 16 to make 17 and after removing a couple patches, it seems to be working so far (compiler-rt built, clang just finished). There will probably have to be some patch changes but so far, things are working.

@reckenrode
Copy link
Contributor

reckenrode commented Oct 8, 2023

I have a couple of Darwin-related questions:

  1. Enable cross-compilation between both Darwin platforms #256590 fixes Darwin cross. Should I wait for that to be merged before suggesting Darwin cross changes (or do it in a separate PR depending on timing)?
  2. libc++ 17 requires the 10.13. SDK to build. Is the plan to revert llvm/llvm-project@c73c3a0 (and hope nothing else requiring 10.13 has crept into libc++), or is x86_64-darwin going to be broken until the SDK is bumped?

@RossComputerGuy
Copy link
Member

@reckenrode I can try things out since my ARM machine is Apple Silicon. I'm mainly focused on Linux on ARM but I can try out the ARM Darwin support and patch if necessary.

@reckenrode
Copy link
Contributor

reckenrode commented Oct 8, 2023

@reckenrode I can try things out since my ARM machine is Apple Silicon. I'm mainly focused on Linux on ARM but I can try out the ARM Darwin support and patch if necessary.

aarch64-darwin should be fine. Its SDK is 11.0. The issue with x86_64-darwin is it’s still using the 10.12 SDK by default (see #101229), and work on updating it is in progress. This doesn’t affect #234710, but it’ll be an issue for the Darwin stdenv once LLVM 18 is released next year.

@Artturin
Copy link
Member

Should we just remove _git? Opened #269994 for discussion.

@rrbutani rrbutani added the 6.topic: llvm/clang Issues related to llvmPackages, clangStdenv and related label May 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0.kind: packaging request Request for a new package to be added 6.topic: llvm/clang Issues related to llvmPackages, clangStdenv and related
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants