Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build failure: luaPackages.lua-resty-openidc #291995

Closed
Qyriad opened this issue Feb 28, 2024 · 5 comments
Closed

Build failure: luaPackages.lua-resty-openidc #291995

Qyriad opened this issue Feb 28, 2024 · 5 comments
Labels

Comments

@Qyriad
Copy link
Member

Qyriad commented Feb 28, 2024

Steps To Reproduce

  1. build pkgs.lua.pkgs.lua-resty-openidc, alternatively with any of the other Lua package sets like luajit.pkgs or openresty_luajit.pkgs
  • I reproduced with exactly: nix build 'github:NixOS/nixpkgs/master#pkgs.luajit.pkgs.lua-resty-openidc', and also with current nixpkgs-unstable

Build log

structuredAttrs is enabled
@nix { "action": "setPhase", "phase": "unpackPhase" }
Running phase: unpackPhase
unpacking source archive /nix/store/h767acipc0afx3079f3xjjg87051kh61-lua-resty-openidc-5a7b9e2
source root is lua-resty-openidc-5a7b9e2
@nix { "action": "setPhase", "phase": "patchPhase" }
Running phase: patchPhase
@nix { "action": "setPhase", "phase": "updateAutotoolsGnuConfigScriptsPhase" }
Running phase: updateAutotoolsGnuConfigScriptsPhase
@nix { "action": "setPhase", "phase": "configurePhase" }
Running phase: configurePhase
@nix { "action": "setPhase", "phase": "buildPhase" }
Running phase: buildPhase
@nix { "action": "setPhase", "phase": "installPhase" }
Running phase: installPhase
Missing dependencies for lua-resty-openidc 1.7.6-3:
   lua-resty-session >= 2.8, <= 3.10 (not installed)

lua-resty-openidc 1.7.6-3 depends on lua >= 5.1 (5.1-1 provided by VM)
lua-resty-openidc 1.7.6-3 depends on lua-resty-http >= 0.08 (0.17.1-0 installed)
lua-resty-openidc 1.7.6-3 depends on lua-resty-session >= 2.8, <= 3.10 (not installed)
Warning: Failed searching manifest: Failed downloading https://luarocks.org/manifest-5.1 - no downloader tool available, please install wget or curl in your system
Warning: Failed searching manifest: Failed downloading https://raw.githubusercontent.com/rocks-moonscript-org/moonrocks-mirror/master/manifest-5.1 - no downloader tool available, please install wget or curl in your system
Warning: Failed searching manifest: Failed downloading https://luafr.org/luarocks/manifest-5.1 - no downloader tool available, please install wget or curl in your system

Error: Could not satisfy dependency lua-resty-session >= 2.8, <= 3.10: No results matching query were found for Lua 5.1.

Additional context

lua-resty-session's README mentions

Note: Version 4.0.0 was a rewrite of this library with a lot of lessons learned during the years. If you still use older version, please refer old documentation.

lua-resty-openidc requires <= 3.10, and given that v4 was a major breaking change, would it make sense to maintain a lua.pkgs.lua-resty-session_3 or similar? I can PR this if that's acceptable.

Notify maintainers

@teto

Metadata

[user@system:~]$ nix-shell -p nix-info --run "nix-info -m"
 - system: `"x86_64-linux"`
 - host os: `Linux 6.1.76, NixOS, 24.05 (Uakari), 24.05.20240221.0e74ca9`
 - multi-user?: `yes`
 - sandbox: `yes`
 - version: `nix-env (Nix) 2.19.3`
 - channels(root): `""`
 - nixpkgs: `/nix/store/gzf4zwcakda1nykn6h0avh45xhjhvsz4-source`

Add a 👍 reaction to issues you find important.

@Qyriad Qyriad added the 0.kind: build failure A package fails to build label Feb 28, 2024
@teto
Copy link
Member

teto commented Feb 28, 2024

There doesn't seem to be much interest in this package as I've seen it broken for a long time, dont hesitate to mark yourself as maintainer.
Ideally there would be a lua-resty-openidc that supports the new version. Do you know about the status of such project ?

lua.pkgs.lua-resty-session_3 or similar? I can PR this if that's acceptable.

It would be the first in the lua package set (haskell does it a lot) but yes it's acceptable. Alternatively you can use your own .csv file with the nixpkgs script to maintain an out of tree lua overlay if that's more convenient for you https://nixos.org/manual/nixpkgs/stable/#developing-with-lua

@teto
Copy link
Member

teto commented May 13, 2024

@Qyriad with ZHF coming up, I wonder what to do. Which way did you go ? Should I mark the package as broken or were you able to find a solution ?

@Qyriad
Copy link
Member Author

Qyriad commented May 19, 2024

@teto thank you for reminding me about this. I had put an inline package definition for lua-resty-session 3.10 in my config, but it seems that in the meantime lua-resty-jwt, another dependency of lua-resty-openidc, has also broken, which I had not noticed until now and haven't debugged yet

@poscat0x04
Copy link
Contributor

poscat0x04 commented Jun 1, 2024

cp: cannot stat 'third-party/lua-resty-hmac/lib/resty/hmac.lua': No such file or directory

Error: Build error: Failed installing third-party/lua-resty-hmac/lib/resty/hmac.lua in /nix/store/f4fal2fi7807m92iyw7rni7pcgpx

It seems that lua-resty-jwt is broken cause it didn't fetch submodules.

Edit: apparently there's already a PR #314863

@poscat0x04
Copy link
Contributor

I think this can be closed now since #294057 has been merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants