Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nixpkgs committers interest list #321665

Open
Mic92 opened this issue Jun 22, 2024 · 90 comments
Open

Nixpkgs committers interest list #321665

Mic92 opened this issue Jun 22, 2024 · 90 comments

Comments

@Mic92
Copy link
Member

Mic92 commented Jun 22, 2024

Hi, the purpose of this issue is to nominate new nixpkgs contributors for commit access to nixpkgs. The process is described in nixpkgs-committers org documentation.

@lorenzleutgeb's script also wrote a script to summarize past github contributions. However more importantly we value when nominees work well together in the community and take ownership for their mistakes.

If you have questions regarding becoming a nixpkgs maintainer, you can contact the Nixpkgs committer delegation team:

@mweinelt
Copy link
Member

mweinelt commented Jul 4, 2024

I want to nominate @emilazy, who recently carried the OpenSSH SIGALARM vulnerability across all branches and even wrote an advisory and took the time to answer questions and construct a timeline.

Emily has 75 merged PRs and over 100 reviewed PRs. She has been contributing on and off since 2019, and contributed for example the initrd OpenSSH migration.

I think it would be beneficial to further enable a capable person like her.

@emilazy
Copy link
Member

emilazy commented Jul 4, 2024

Thank you for the nomination! I’d be happy to accept the commit bit if offered. I’ve frequently had long absences from FOSS work in the past several years, so I can’t guarantee availability, but I’d like to be able to contribute more consistently going forward. In the wider ecosystem I’m also a nix-darwin committer so I’m reasonably familiar with the module system, and I helped nix-darwin and Home Manager migrate from the old DocBook documentation toolchain to unblock its removal from Nixpkgs. The biggest thing I’ve done recently was working on removing Mesa as a channel blocker on Darwin, which had caused significant issues and friction in the past. I’m a user of both macOS and Linux and would like to continue to help bridge the gap between the two platforms in terms of maintenance and quality.

@willcohen
Copy link
Contributor

willcohen commented Jul 4, 2024

I’d like to apply for the commit bit (and also happy to wait if that makes more sense.)

My first contribution and introduction to Nix was in 2021-2022, to upstream to QEMU an old patchset to enable 9pfs on Darwin, thus allowing for fixing up remote file support on QEMU and thus lima and podman on Mac, with many thanks to @alyssais and @domenkozar in guiding me through all that: #122420

Since then, I’ve added a couple smaller packages and fixed up others to work better on Mac. My focuses are around GIS software on Mac (my longstanding white whale is to get QGIS working on Mac, which is both close and far: #157862), keeping emscripten up to date (usually some LLVM tip of tree backports with the help of @RaitoBezarius), Clojure stuff, the occasional dabbling in random JS or Perl packages here and there, and fixing broken things on Mac. I’ve been a little quieter the last year as work focuses pulled me a bit away from programming, but I’m working my way back in to it this summer. I know there’s a perennial need for capacity on Darwin (ie #323144) and that a combo of lack of testing and lack of ability to review or land fixes is a big pain point, and would mostly like to help keep those PRs moving in a timely manner.

58 merged PRs: https://github.com/NixOS/nixpkgs/pulls?q=sort:updated-desc+is:pr+author:willcohen+is:merged

52 reviews:
https://github.com/NixOS/nixpkgs/pulls?q=sort:updated-desc+is:pr+reviewed-by:willcohen+-author:willcohen (edited to remove my own PRs, thanks @eclairevoyant)

No NixOS modules yet — I’m still predominantly Mac-centric, though I sometime play with it in a VM.

@eclairevoyant
Copy link
Contributor

76 reviews of closed PRs, though probably a third of those are nixpkgs-review output of my own PRs:

You can filter those out with -author:willcohen; filtering out own PRs should be done in general for all PR review queries.

@lorenzleutgeb
Copy link
Member

You can filter those out with -author:willcohen; filtering out own PRs should be done in general for all PR review queries.

I added this condition to the script mentioned in OP.

@gador
Copy link
Member

gador commented Jul 20, 2024

I like to express my interest in a commit bit, too.
I've been working with NixOS and nixpkgs since 2021 and started contributing since then. Currently I maintain or co-maintain 51 packages.
Recently I wrote the blendfarm module and updated a few modules in the past.
I have the most experience with python, but also some experience with c++, qt, shell and a bit of go. My usual systems involve x86_64-linux, but I also have aarch64-linux and aarch64-darwin systems on which I can test packages or modules.

I'd like to use my commit bit to help merge already reviewed packages and to reduce the time it takes to merge simple updates. When time permits, I look through the pr ready for review thread on discourse and add my 2 cents.

@Mic92
Copy link
Member Author

Mic92 commented Jul 22, 2024

@emilazy @gador @willcohen Welcome to the team! Sorry for the delay. We (nixpkgs team admins) are currently discussing, where we are moving future applications, but until then we stick to this issue.

@infinisil
Copy link
Member

I'd like to nominate @philiptaron! They've been super helpful in co-maintaining https://github.com/NixOS/nixpkgs-check-by-name, but have also been active in Nixpkgs with

@donovanglover
Copy link
Member

I'm interested in committer rights to merge the pull requests of others and update packages I maintain.

Notable PRs:

Stats:

@mattpolzin
Copy link
Contributor

I'm interested in commit privileges. I reckon I'm on the low end for existing contributions to nixpkgs so no hard feelings if I just don't have the exposure yet to warrant committing; I think my bid for more responsibility is as much grounded in my record of maintenance across a number of OSS communities (most recently Idris2 and beam-community) as it is in nixpkgs PRs merged thus far. The reason I believe that is relevant is because I know how to show restraint and gradually assert myself in more places as I gain confidence that I know the established precedents.

My primary areas of interest in nixpkgs are: The Elixir ecosystem (PRs), Idris2 (PRs), and Darwin (PRs). I also have a vested interest in the Ruby ecosystem, NixOS, and the overall health and success of nixpkgs!

@Mic92
Copy link
Member Author

Mic92 commented Jul 31, 2024

@philiptaron welcome to the team.

@Mic92
Copy link
Member Author

Mic92 commented Aug 2, 2024

@donovanglover welcome to the team as well.

@Mic92
Copy link
Member Author

Mic92 commented Aug 2, 2024

@mattpolzin Not a reject, but none of us (@jtojnar, @NickCao and me) knows you very well, so we would like to know if there is a person from the community you have interacted with and who can vouch for you?

@mattpolzin
Copy link
Contributor

mattpolzin commented Aug 2, 2024

@Mic92 Sure, that's fair. I'm not sure if any single existing Nixpkgs committer has interacted with me in more than one context so it's quite possible no one would say they know me well (yet). I'd mention @happysalada or @fabianhjr who I think have had positive experiences working with me in the context of Elixir and Idris2 packaging but I definitely won't feel slighted if they don't feel they are ready to vouch for me at this point. I believe the folks maintaining Bruno with me have seen me be responsive, knowledgable, constructive, etc. but last I checked none of us are committers (so no one to suggest vouches for me there).

@fabianhjr
Copy link
Member

Can vouch about positive interactions here on nixos and on some idris stuff a while back

@happysalada
Copy link
Contributor

Same here, i can vouch for positive interactions. I think the beam maintainers could definitely benefit from having more people.

@JohnRTitor
Copy link
Contributor

JohnRTitor commented Aug 4, 2024

I'd like to nominate @AndersonTorres. I was surprised that they aren't a commiter already, despite their HUUGE contributions. My personal interactions with them have been very civil and I have learnt a thing or two from them in my novice days (still learning).

I was surprised to see they aren't a commiter already.

@doronbehar
Copy link
Contributor

I too feel that @AndersonTorres is very dedicated, and very motivated - which explains their thorough contributions. However I personally experienced stubborn communication with him (also here), which makes me a bit worried to be fully honest. I deeply appreciate though the PRs that remove the inactive maintainers (see #290642).

I was surprised to see they aren't a commiter already.

They were in the past, and got removed.

@Atemu
Copy link
Member

Atemu commented Aug 4, 2024

I can mirror @doronbehar's opinion but want to add that my interactions with them have not improved significantly since they lost their commit access. I think it'd be better to keep it that way for now.

@Mic92
Copy link
Member Author

Mic92 commented Aug 10, 2024

@mattpolzin based on @happysalada and @fabianhjr's feedback, we have decided to give you nixpkgs commit access. Welcome.

@drupol
Copy link
Contributor

drupol commented Aug 11, 2024

Hello there,

I'd like to nominate @felschr.

He has 123 authored & closed PRs, 174 reviewed & closed PRs, and he maintains about 18 packages.

His main focus is on maintaining Tor Browser & Mullvad Browser. Many of the updates are security critical and it could be good having an active package maintainer who can merge them.

He also created the etebase-server NixOS module a while ago and made some smaller improvements to other modules (e.g. cfdyndns, mosquitto, ddclient).

I personally had the chance to interact with him on PRs and all the interactions were pretty good and respectful.

@emilazy
Copy link
Member

emilazy commented Aug 19, 2024

I’d like to nominate @tie, if he’s interested. He has been contributing since late 2022, and has recently been doing very high‐quality and in‐depth work covering the spectrum from extensive work on the Node.js package, through a rework of a core Darwin tool switching from an unmaintained fork to a clean set of patches on top of the latest upstream release, to fixes and various enhancements to stdenv. He has also brought his invaluable Bash expertise to reviews of various pull requests, including #318614 and #331560. The raw PR counts may be lower than many new committers, but in my judgement they are of a high standard and frequently high‐effort, and I have found him a pleasure to work with.

@minijackson
Copy link
Member

Hi everyone! I'd like to apply for committer access. I've been a member of the NixOS GitHub organization since 2020, and have been active in various parts, like cross-compilation (1, 2), systemd journal remote, NetBox, Jellyfin, etc.

@tie
Copy link
Member

tie commented Aug 23, 2024

@emilazy, thank you, it’s been a pleasure working with you and @philiptaron as well! I have more computers than I probably need in my homelab, so my focus in NixOS/Nixpkgs/Nix is support for building packages for different platforms (i.e. cross-compilation). I’m mostly contributing in my free time, but we also use NixOS at my current job. I’m not opposed to getting committer access, but I hope I can be of help with stuff I’m familiar with regardless of the commit bit.

@Mic92
Copy link
Member Author

Mic92 commented Dec 17, 2024

Also a project of @hsjobeki : https://noogle.dev/
I think @infinisil worked with him as well more closely on lib related changes?

@infinisil
Copy link
Member

infinisil commented Dec 19, 2024

Yeah I've started chatting with @hsjobeki on a weekly basis to mentor him on lib and module system maintenance and improvements, and it's going very well. While I don't think he's fully ready to merge many things on his own yet, I already trust him to use commit access responsibly, so he's getting my endorsement!

@hsjobeki In case you do get commit access, let's chat before merging anything so I can tell you what to watch out for :)

Edit: I just wrote down an idea to make committer mentoring more common, check out NixOS/org#48

@adrian-gierakowski

This comment was marked as outdated.

@jian-lin

This comment was marked as outdated.

@adrian-gierakowski

This comment was marked as outdated.

@Ericson2314
Copy link
Member

I'd like to nominate @rhelmot and @artemist to be Nixpkgs committers, especially for the sake of FreeBSD where they are holding down the fort.

(Noting conflicts of interest: I am working with them commercially on some OpenBSD things.)

@stepbrobd
Copy link
Member

I would like to apply for the committer bit. I've been active for the past two years, moving forward, I'd like to help clearing up some of the PR backlogs and be more vocal in the Coq portion of nixpkgs (currently planning a refactoring)

@phaer
Copy link
Member

phaer commented Jan 7, 2025

I would like to apply for commit bit to help with the backlog of PRs.

For my PRs to nixpkgs, see

I wrote a short paragraph about my background & community involvement over the last ~3 years in my (unsuccesful) bid to the sc

I had positive interactions with many amazing community members both online and offline. In recent months I contributed a bunch of cleanups and new features around disk image generation in nixpkgs, besides that I help maintaining our playwright packaging, services like tailscale-nginx-auth or healthchecks.
I also did lot's of mistakes already and tried to own them as much as I could. E.g. I did mass-ping 300+ people when that was still possible here ;)

@Atemu
Copy link
Member

Atemu commented Jan 7, 2025

@stepbrobd I have taken note of you before and I think you're on the right track but I think I'd personally like to see a little more of you to be convinced.

This is just a feeling of mine though; if others had closer interactions with you and think you're worthy, I'd like them to speak up and overrule me.

I have similar feelings about @phaer but I've seen you around for quite a bit longer IIRC. Additionally though, being a maintainer of dream2nix, disko and nixos-anywhere aswell as working for numtide where I'm sure you're being mentored and/or have Nixpkgs expertise close at hand make me feel quite comfortable with you joining the committer team.

Again though, this is opinion n=1 and I don't get to decide this.

@JohnRTitor
Copy link
Contributor

I am endorsing @rhelmot as well, I have had the pleasure of reviewing a few of their PRs. Very easy to work with, and has done a lot of good work on FreeBSD support. Having more FreeBSD commiters/reviewers will help encourage more FreeBSD related contributions and fast paced development on that front.

There was a massive FreeBSD PR (#320475) last year which took the first step and booted a NixBSD system.

@JohnRTitor JohnRTitor changed the title Nixpkgs committers list Nixpkgs committers interest list Jan 10, 2025
@Mic92
Copy link
Member Author

Mic92 commented Jan 20, 2025

Sorry for the delay. It's mostly on my site that we build up a bit of a backlog.
Welcome to the team: @pyrox0 and @msanft
We still have to test what the best way to assign mentors is.
For this round I assigned @tomodachi94 to @pyrox0 and @katexochen to @msanft
as mentors, so if you have any questions please reach out to these people.

@Mic92
Copy link
Member Author

Mic92 commented Jan 20, 2025

@rhelmot @artemist @hsjobeki welcome to the nixpkgs team.

@rhelmot @artemist I assigned you @Ericson2314 as a mentor
@hsjobeki I assigned you @infinisil as a mentor regarding questions.

@Mic92 Mic92 changed the title Nixpkgs committers interest list Nixpkgs committers list Feb 2, 2025
@Mic92 Mic92 changed the title Nixpkgs committers list Nixpkgs committers interest list Feb 2, 2025
@9999years
Copy link
Contributor

9999years commented Feb 11, 2025

Hello, I'd like to register interest for Nixpkgs committer access.

For a little more context: I currently work on Nix packaging at Mercury with @lf- and @Gabriella439. I have also collaborated with @infinisil in my capacity as a Mercury engineer.

@niklaskorz
Copy link
Contributor

niklaskorz commented Feb 11, 2025

I too would like to apply for nixpkgs commit bit. I have been using Nix privately since December 2022 and at work since January 2023, where I maintain a Nix-based CI/CD pipeline for a monorepo. I daily-drive NixOS on my desktop PC and nix-darwin on my Macbook, as well as NixOS on my Raspberry Pi, my own private server and a few servers at work with lots of different services.

  • 70 PRs merged
  • 108 PRs reviewed
  • nixpkgs maintainer since December 2023
  • maintaining 12 packages and contributed to lots of others
  • maintaining three NixOS modules (mautrix-signal, conduwuit, fider) and contributed to others

I personally love to bring Nix and NixOS closer to new users, as well as help new nixpkgs contributors to reduce any onboarding pains where possible.
To that end, I'm also organizing the local Mannheim and Heidelberg NixOS meetups since December 2023 (you can find recordings of our meetup talks on PeerTube :).

I'm fairly active on Matrix as well, where I try to help out with any problems concerning Rust or darwin.
I also joined the darwin-maintainers team a few months ago to help out with PRs needing reviews for or being blocked by darwin issues.

Other committers that I think I have been interacting with the most are @GaetanLepage, @emilazy, @drupol and @bbigras. I also asked @GaetanLepage if he'd be willing to be my mentor if I'm accepted and he agreed (it wasn't quite clear to me whether we should be looking for mentors ourselves yet, but I figured it wouldn't hurt).

If you've interacted with me on Matrix or Discord, you might recognize me from my avatar (which is a photo of Loki, one of our two beloved black cats):

Loki the cat

@GaetanLepage
Copy link
Contributor

I too would like to apply for nixpkgs commit bit.

I fully endorse @niklaskorz 's application to the commit bit. His contributions have been of a very high technical quality.
Niklas has shown professional behavior on multiple occasions. It truly is my pleasure to interact with him in PR threads and on matrix.
Indeed, he is a very nice, positive, and serious individual. I would be glad to count him on the team to let him fully unleash his potential and help the project strive even more!

Also, I would be honored to be his mentor. I am sure I can learn at least as many things from him as he can do from me :)

@lf-
Copy link
Member

lf- commented Feb 11, 2025

I endorse @9999years's application. Though I disclose the conflict of interest that she is my coworker as noted above (and her receiving the commit bit would make my job easier at work), I've worked with her outside of my current job for years before and can attest to her caring about quality and effective processes and having an impressive drive to make projects as nice to work on as possible (including and especially by saying "no" where it's appropriate).

@nixos-discourse
Copy link

This issue has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/25-05-call-for-release-manager-editor/59765/8

@jian-lin
Copy link
Contributor

Since one privilege of a committer is to merge PRs, I expect to see some amount of review done by people applying for commit access. However, IMHO, the review done by @9999years seems not enough.

@hadilq
Copy link
Contributor

hadilq commented Feb 12, 2025

Hey everyone, I want to nominate @numinit, who created the Android team. Also he is one of the main contributors to androidenv, who constantly contribute and update the code. It would be great if we have him as a committer so in the Android team we could iterate faster on the features and problems. Thank you!

@numinit
Copy link
Contributor

numinit commented Feb 14, 2025

Thank you for the nomination @hadilq! I have been learning the nixpkgs deep magic with the help of @RossComputerGuy most recently, including help with team creation and figuring out various ARM64 and Darwin issues. My most recent projects are creating a virtual multi-node WiFi testbed and enabling Mattermost's 17000 test suite on Hydra. For the Android team, I hope to add an option to unvendor Google's precompiles of clang and cmake for the NDK, and am working on automatic updates that track Google's latest repos.

Obligatory stats:

@Bot-wxt1221
Copy link
Member

Bot-wxt1221 commented Feb 17, 2025

I would like to nominate myself as a committer. It has been about 1 year since I submitted my first PR #308986. I'm interested in adding useful package to nixpkgs. I'm also the maintainer of https://github.com/nix-community/nix4nvchad, which is used by many nvchad's user. I also help fix many broken package especially python packages. However, I've been realised that it is too slow to merge neccessary PRs.

By the way, I'm not really a robot. 😰

@megheaiulian
Copy link
Contributor

megheaiulian commented Feb 20, 2025

I would like to nominate myself as a committer. I mainly am interested in keeping existing packages up-to-date and fix them when they are broken.

@matteo-pacini
Copy link
Contributor

matteo-pacini commented Feb 25, 2025

Hi everyone,
I'd like to nominate myself for the commit bit. I've been part of the community since June 2024, and I'd like to help speeding up PR reviews and merging wherever possible.

I maintain around ~23 packages, mostly Darwin (iOS dev by day), but I don't mind picking up Linux stuff too.
https://repology.org/projects/[email protected]&inrepo=nix_unstable

I've converted all of my Gentoo systems at home into NixOS, I'm fully invested into Nix/NixOS/Nixpkgs and the community.
Also started replacing my Homebrew-based dev workflows both at home and at work, and it's been absolute bliss.

Interesting bits of work:

Stats:

@9999years
Copy link
Contributor

@jian-lin Thanks for the feedback! I've been working on reviewing more PRs. I'm up to 64 reviews now, which is more in line with previous accepted applications.

@illustris
Copy link
Contributor

I'd like to nominate myself as a commiter. I've been using and contributing to nixpkgs since 2021: #109114

Notable things I've worked on:

Stats:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests