Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Potentially incorrect warps #328

Open
exectails opened this issue Oct 6, 2024 · 0 comments
Open

Potentially incorrect warps #328

exectails opened this issue Oct 6, 2024 · 0 comments
Labels
enhancement This issue is about improving the quality of code or a feature. help wanted This issue requires help from other contributors.

Comments

@exectails
Copy link
Member

exectails commented Oct 6, 2024

It's been brought to my attention that some of our current warps might not be entirely correct, while others are missing entirely. Since our warps are based on client data, they were assumed to be correct, but that might actually be the case, and we might also be missing special server-side-only warps.

many dungeon warps are missing. I know some have quest requirements and some don't use normal warp arrow NPCs (like demon prison) so those are not in melia. As for normal warps between maps, it seems there are a few completely wrong ones and some are going through the ground I believe because height check fails near the corner of the maps (and warps are typically very close to corners).
one improvement we could do is get the nearest spot that has valid ground data when placing a warp, that would fix most if not all of the ones going through the ground

As such, it would be good if we'd travel around the world a little and confirm if warps generally are where they're supposed to be, ideally comparing them to officials, and also find and potentially add special warps not covered by the normal client data. Such as Shaton Reservoir, which

has a bunch of moles and the player can dig through the mole holes (NPCs) to warp from one "island" to another. These NPCs are missing in melia so obviously there's no way to traverse the map.

This might be a good job for someone who knows the game world well and would notice warps being missing or placed incorrectly. But the recent Melia change to finally display warps on the minimap will also make this easier.

The current warp scripts can be found here: system/scripts/zone/content/r1/warps

@exectails exectails added enhancement This issue is about improving the quality of code or a feature. help wanted This issue requires help from other contributors. labels Oct 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement This issue is about improving the quality of code or a feature. help wanted This issue requires help from other contributors.
Projects
None yet
Development

No branches or pull requests

1 participant