Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple Shoutboxes on One Site #53

Open
shaneedwards opened this issue Jul 27, 2014 · 9 comments
Open

Multiple Shoutboxes on One Site #53

shaneedwards opened this issue Jul 27, 2014 · 9 comments

Comments

@shaneedwards
Copy link

I love your plugin, and my very young community is finding it handy as well. In this case we have 4-5 distinct groups of people who are looking for this exact functionality but would like to have 4-5 shoutboxes in the header of the site with different names for each.

BreakMeta

This is a League of Legends community and they want a shoutbox for each of the major player regions around the world like North America, EU, Korea, etc.

Thanks!

@Schamper
Copy link
Collaborator

So what's the issue?

@shaneedwards
Copy link
Author

Intended as more of a feature request (unless I missed the ability to do it already).

On Jul 27, 2014, at 4:35 PM, Erik Schamper [email protected] wrote:

So what's the issue?


Reply to this email directly or view it on GitHub.

@shaneedwards shaneedwards changed the title Multiple Shoutboxes on One Sire Multiple Shoutboxes on One Site Jul 27, 2014
@Schamper
Copy link
Collaborator

Just thought about it some more (very tired, excuse me), and I now see what the issue would be. Unfortunately this would require a lot of work for a very specific use case, so I probably won't support this, not anytime soon anyway. Sorry.

@Schamper
Copy link
Collaborator

Just throwing ideas here for when I will have the time to implement this:

  • Admin needs to be able to somehow adjust the "Shoutbox ID" of a widget
    • (Need to verify) Don't think this is possible with the current widget implementation
    • Probably need to do this on the ACP page of the Shoutbox
  • Shouts will be stored under this selected ID e.g. shouts:id:sid
  • Existing shouts in the database will need to be moved.
  • Client side will have to be fully refactored to support this, events might be tricky.

Possible issues:

  • Shoutbox settings, do they apply for all the shoutbox instances or are they individual for each shoutbox instance? E.g. allow certain features in shoutbox 1 but not in shoutbox 2.
    • This also applies for the muted users of a certain user, as well as banned users.

Will comment with further ideas when I think of them.

@shaneedwards
Copy link
Author

Awesome! Thanks for considering it.

If it would make a difference, another way to do it would be a dropdown (or other selector) in the current shoutbox to select which box you want to view/interact with. The data storage and muting side would still have to change, but that might make the front-end implementation a bit easier to deal with.

@hholst80
Copy link

hholst80 commented Aug 6, 2014

Your recent fixes are not available from npm install nodebb-plugin-shoutbox? Did you forget to upload it to npm central repository? :P

@Schamper
Copy link
Collaborator

Schamper commented Aug 7, 2014

@hholst80 I didn't forget, it's just that I haven't had the time yet to properly test on 0.5.0, and I secretly still want to implement a couple more features before a new release ;)

Latest repo version should be compatible with 0.5.0 though.

@faizanzahiddeloitte
Copy link

faizanzahiddeloitte commented Oct 13, 2017

Thanks for your awesome work @Schamper .... Is shoutbox working fine with Nodebb 1.6 update? Can we have support for multiple shoutboxes ,emo support and uploading pics in public chat? Please...

@Schamper
Copy link
Collaborator

Hey @faizanzahiddeloitte! You can install it on NodeBB 1.6 and report back if it works or not, and if there are any specific error messages you're seeing. As for all those features, feel free to submit a pull request and I'll gladly merge it into the main repo and publish it on npm. I currently don't have the time to work on such large features myself.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants