Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mnemonic should have logging integrated. Right now there is no logging available. #2

Open
umamaheswararao opened this issue Feb 9, 2016 · 2 comments

Comments

@umamaheswararao
Copy link

example:
in BigDataMemAllocator.java

static {
try {
NativeLibraryLoader.loadFromJar("bigdatamem");
} catch (Exception e) {
System.exit(-1);
}
}
We should have log here. IMO, we should not use System.exit in this module. Otherwise, other user system will shutdown unknowingly. We should have mechanism to let user application know about the issue, rather than silently shutting down.

@AI-Memory
Copy link
Member

will add logging for diagnose, information and errors, Thanks.

@AI-Memory
Copy link
Member

the system.exit() call has been removed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants