-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HstsResolver mishandles country code second-level domains #785
Comments
A new snapshot release was just made with a fix that now considers the "effective" top-level domain for a URL instead of just the last two parts of the domain. It is using the Public Suffix List as you suggested. That being said, you will still get a warning/exception. The reason is, that your public suffix is To ensure only
|
Thank you very much for fixing it.
Actually, the URL I shared was just an example which I randomly picked from sites I was familiar with. However, your suggestions to mitigate another error message are very helpful. I'm looking forward to a new release with the fix. |
Summary
HstsResolver
doesn't handle country code second-level domains (e.g.co.jp
) well and emits a WARN log and fails to check HSTS support correctly.Reproduction
Run a collector with start URL =
https://www.ipsj.or.jp/english/index.html
.Actual behavior
HstsResovler
tries to communicate withor.jp
and emits a WARN message:Expected behavior
HstsResovler
tries to communicate withipsj.or.jp
.Resources
under which Internet users can (or historically could) directly register names
(not just country specific ones). It also provides information about Java libraries.The text was updated successfully, but these errors were encountered: