New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Boolean should be encodable value as well #212

Open

fairlane opened this issue May 10, 2019 · 0 comments

Labels

Contributor

fairlane commented May 10, 2019

https://github.com/Nosto/nosto-php-sdk/blob/develop/src/Helper/HtmlMarkupSerializationHelper.php#L238.

Not allowing booleans becomes problematic especially with collections with mixed strings, nulls and boolean (custom fields for example)

fairlane added the enhancement label

fairlane added this to the 3.15.0 milestone

fairlane modified the milestones: 3.15.0, 4.0.0, 4.0.1

fairlane removed this from the 4.0.1 milestone

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment