Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use .NET SDK 9.0.2xx to build repository and .NET SDK 9.0.3xx for integration tests #6285

Open
wants to merge 2 commits into
base: dev
Choose a base branch
from

Conversation

jeffkl
Copy link
Contributor

@jeffkl jeffkl commented Feb 24, 2025

Use .NET SDK 9.0.2xx when building our repository and .NET SDK 9.0.3xx for the .NET integration tests.

You can look at https://github.com/NuGet/NuGet.Client/commits/dev/build/DotNetSdkTestVersions.txt for more examples of when this configuration is changed.

This also started setting the MSBuild property BuildWithNetFrameworkHostedCompiler so that the compilers aren't downloaded as NuGet package when tests are running.

@jeffkl jeffkl added the Engineering Changes related to the build infrastructure of the repo and that do not change product code label Feb 24, 2025
@jeffkl jeffkl self-assigned this Feb 24, 2025
@jeffkl jeffkl requested a review from a team as a code owner February 24, 2025 22:57
jebriede
jebriede previously approved these changes Feb 25, 2025
Copy link
Contributor

@jebriede jebriede left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Could you add a short description of why we're making this change?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Engineering Changes related to the build infrastructure of the repo and that do not change product code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants