Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove remenants of old file files from dist branch #42

Open
JackNoordhuis opened this issue Dec 11, 2024 · 0 comments
Open

Remove remenants of old file files from dist branch #42

JackNoordhuis opened this issue Dec 11, 2024 · 0 comments

Comments

@JackNoordhuis
Copy link
Member

JackNoordhuis commented Dec 11, 2024

Although the package.json main and types fields point to the correct files, the old files have not been removed by create-pull-request step of CI.

https://github.com/NxtLvLSoftware/alpine-typescript/blob/39598c13df0da8b08484eb8ceaac00754bc3e4a4/index.d.ts

https://github.com/NxtLvLSoftware/alpine-typescript/blob/39598c13df0da8b08484eb8ceaac00754bc3e4a4/index.js

This should not cause any issues (code/IDE wise as paths are specified correctly) but will be confusing for developers browsing the source. Ideally, the create-pull-request step should deal with this automatically in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant