-
-
Notifications
You must be signed in to change notification settings - Fork 227
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[16.0][ADD] stock_account_lot_expiration_date #349
base: 16.0
Are you sure you want to change the base?
[16.0][ADD] stock_account_lot_expiration_date #349
Conversation
1fb4943
to
81044da
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review: Great work! The code looks good to me (LGTM). Thank you for your contribution! I've provided a few suggestions for your consideration—feel free to address them as you see fit.
import logging | ||
|
||
from odoo import models | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
from odoo.tools.misc import format_date | |
lot.expiration_date.strftime( | ||
self.env["res.lang"]._lang_get(lang).date_format |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lot.expiration_date.strftime( | |
self.env["res.lang"]._lang_get(lang).date_format | |
format_date(self.env, lot.expiration_date) |
self.assertEqual(len(lot_values), 1) | ||
self.assertEqual( | ||
lot_values[0]["expiration_date"], | ||
date(2025, 1, 31).strftime(self.lang.date_format), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think here You can use the misc format_date function too
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Functional review: LGTM👍
This PR has the |
1 similar comment
This PR has the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Functional review: LGTM
Good morning, this development adds the expiration date by lot to the invoice report.