Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

quality_control cannot add trigger line models without overriding method #1037

Closed
diggy128 opened this issue May 15, 2023 · 1 comment
Closed
Labels
stale PR/Issue without recent activity, it'll be soon closed automatically.

Comments

@diggy128
Copy link

Inherited trigger line models in quality_control_mrp and quality_control_stock are hardcoded in the methods.

To add an extra trigger line model one must override all methods to add model.
Offending lines:
https://github.com/OCA/manufacture/blob/47548543760eab4e8c188cb408729025c2d0df98/quality_control_mrp/models/mrp_production.py#L38C8-L40

I would propose to create a list variable in qc_trigger_line.py that will hold all trigger model names so that extending would require only adding the model to that list.

If you accept this issue I'll come back with a PR.

Copy link

There hasn't been any activity on this issue in the past 6 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this issue to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Nov 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stale PR/Issue without recent activity, it'll be soon closed automatically.
Projects
None yet
Development

No branches or pull requests

1 participant