From fdfc72bcbaa57a9655b744fb6d89c93097858cc2 Mon Sep 17 00:00:00 2001
From: Denis Roussel <denis.roussel@acsone.eu>
Date: Mon, 29 Apr 2024 13:24:42 +0200
Subject: [PATCH] [IMP] product_packaging_level: Rely on 'qty' field too to
 compute the qty_per_level field

In the product packaging Form view, rely also on 'qty' field to have a coherent behaviour
for the display of qty_per_level field.

In that case, self.id == NewId, so compare ids field instead which is always a list of integers.
---
 .../models/product_packaging.py               |  3 ++-
 .../tests/test_product_packaging_level.py     | 26 ++++++++++++++++++-
 2 files changed, 27 insertions(+), 2 deletions(-)

diff --git a/product_packaging_level/models/product_packaging.py b/product_packaging_level/models/product_packaging.py
index 1f89f64b158..50ed5d977e8 100644
--- a/product_packaging_level/models/product_packaging.py
+++ b/product_packaging_level/models/product_packaging.py
@@ -71,6 +71,7 @@ def _compute_barcode_required_for_gtin(self):
     @api.depends(
         "product_id",
         "product_id.packaging_ids",
+        "qty",
         "packaging_level_id",
         "packaging_level_id.code",
     )
@@ -88,7 +89,7 @@ def _get_qty_per_level_mapping(self):
         :return: mapping {level.code: qty}
         """
         smaller_product_packagings = self.product_id.packaging_ids.filtered(
-            lambda p: p.id != self.id and self.qty > p.qty > 0.0
+            lambda p: p.ids != self.ids and self.qty > p.qty > 0.0
         )
         res = OrderedDict()
         for p_pack in smaller_product_packagings.sorted(lambda p: p.qty):
diff --git a/product_packaging_level/tests/test_product_packaging_level.py b/product_packaging_level/tests/test_product_packaging_level.py
index 193433899f0..d70c84ecb09 100644
--- a/product_packaging_level/tests/test_product_packaging_level.py
+++ b/product_packaging_level/tests/test_product_packaging_level.py
@@ -1,7 +1,7 @@
 # Copyright 2021 ACSONE SA/NV
 # License AGPL-3.0 or later (https://www.gnu.org/licenses/agpl).
 from odoo.exceptions import ValidationError
-from odoo.tests import common
+from odoo.tests import Form, common
 
 
 class TestProductPackagingLevel(common.TransactionCase):
@@ -184,3 +184,27 @@ def test_packaging_qty_per_level(self):
         self.assertEqual(self.packaging_10.qty_per_level, "6.0 TEST2; 2.0 TEST3")
         # Base packaging has no qty per level
         self.assertEqual(self.packaging.qty_per_level, "")
+
+    def test_packaging_qty_per_level_form(self):
+        """ """
+        self.level_3 = self.env["product.packaging.level"].create(
+            {
+                "name": "Packaging Level 3 Test",
+                "code": "TEST3",
+                "sequence": 3,
+            }
+        )
+        self.packaging_3 = self.env["product.packaging"].create(
+            {
+                "name": "Packaging Test",
+                "packaging_level_id": self.level_3.id,
+                "qty": 3.0,
+                "product_id": self.product.product_variant_ids.id,
+            }
+        )
+        self.assertEqual(self.packaging_3.qty_per_level, "3.0 TEST2")
+        with Form(self.packaging_3) as pack_form:
+            pack_form.qty = 9.0
+            self.assertEqual(pack_form.qty_per_level, "9.0 TEST2")
+        self.packaging_3.invalidate_recordset()
+        self.assertEqual(self.packaging_3.qty_per_level, "9.0 TEST2")