Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[auth_oauth] Automatically redirect to SSO for authentication #749

Closed
madduck opened this issue Jan 15, 2025 · 4 comments
Closed

[auth_oauth] Automatically redirect to SSO for authentication #749

madduck opened this issue Jan 15, 2025 · 4 comments

Comments

@madduck
Copy link

madduck commented Jan 15, 2025

Is your feature request related to a problem?

When OIDC is configured, the user is still presented with a username/password login prompt, and expected to click the button for SSO below:

Image

This is potentially confusing, as users might try to enter user credentials there, which will be refused.

Also, in the standard case, this always requires the same click of a button, which is extra work.

Describe the solution you'd like

When SSO is configured, and a new setting e.g. "Bypass password login" is set to true, the login screen should forward to the SSO provider directly, instead of requiring a button press.

For the case when a local user (e.g. Administrator) needs to log in (SSO provider down, misconfigured, or some other reason), then appending something like ?allauth=1 to the URL would force the current screen despite the aforementioned "Bypass" setting.

Additional context

WikiJS does this nicely:

Image

@sbidoul
Copy link
Member

sbidoul commented Jan 15, 2025

Could be useful, but just noting this feature is not related to the auth_oidc module but rather to the auth_oauth Odoo CE modules.

@madduck
Copy link
Author

madduck commented Jan 16, 2025

@sbidoul okay, I will have to take your word for this.

Meanwhile, I have noticed that auth_saml does seem to provide this feature:

From the README:

If all the users have a SAML id in a single provider, you can set automatic redirection in the provider settings. The autoredirection will only be done on the active provider with the highest priority. It is still possible to access the login without redirection by using the query parameter disable_autoredirect, as in https://example.com/web/login?disable_autoredirect= The login is also displayed if there is an error with SAML login, in order to display any error message.

@vincent-hatakeyama
Copy link
Contributor

#717 implements the feature in 16.0

@vincent-hatakeyama
Copy link
Contributor

#627 Implements the feature better

@sbidoul sbidoul closed this as completed Jan 22, 2025
@sbidoul sbidoul changed the title [auth_oidc] Disable login screen for SSO [auth_oauth] Automatically redirect to SSO for authentication Jan 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants