-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change shared link for resource share #4245
Comments
What if we share the preview link instead ? I know some resources don't really have a preview but we could imagine a version of the preview page even for those. |
I agree, it is a bit weird, but our preview page doesn't look very nice. I think it can be @yumiendo or @amcguire62 's call. Could we perhaps remove the share links from resources? |
I find resource level 'share' lacking bit of information/credentials (user receives a direct link to download and its missing description, meta data, source, etc) my preference would be to remove the share option from resources and we let users 'share' at dataset level only... unless @amcguire62 thinks this is a deal breaker :) In addition - shall we add a bit of details in the 'share' email: Title of dataset (via HDX) <- in the email title
example: |
Sounds good to me! |
+1 good for me also |
I have pushed a change for removing the share link for resources. @yumiendo @danmihaila
Notice that the formatting is gone. To keep it we should probably change the the way this works. Right now the email is actually sent by the user from his email client that automatically opens. To have a nice formatting we would need to send the email from our servers and provide a nice web form for that. |
We currently share the link to the resource which will be either:
Mixpanel can't count downloads from the 2nd situation.
Change the link shared for resource shares to be the dataset page instead.
Tagging @alexandru-m-g in case I've misunderstood something.
The text was updated successfully, but these errors were encountered: