From de5c2c84acdc05fdffd9b9b580912dd97aa7c62e Mon Sep 17 00:00:00 2001
From: catalamarti <marticatalasabate@gmail.com>
Date: Mon, 14 Oct 2024 13:59:44 +0100
Subject: [PATCH] test choices

---
 R/choices.R                           |  2 +-
 R/correctSettings.R                   |  2 -
 tests/testthat/test-choices.R         | 83 +++++++++++++++++++++++++++
 tests/testthat/test-correctSettings.R | 12 +++-
 4 files changed, 95 insertions(+), 4 deletions(-)
 create mode 100644 tests/testthat/test-choices.R

diff --git a/R/choices.R b/R/choices.R
index 27dcc76..4ca7b49 100644
--- a/R/choices.R
+++ b/R/choices.R
@@ -60,7 +60,7 @@ getChoices <- function(result, flatten = FALSE) {
       tidyCols
     )
   } else {
-    choices <- names(variables) |>
+    choices <- unique(c(names(settings), names(grouping), names(variables))) |>
       purrr::set_names() |>
       purrr::map(\(x) list(
         settings = settings[[x]],
diff --git a/R/correctSettings.R b/R/correctSettings.R
index cea4298..e189e3f 100644
--- a/R/correctSettings.R
+++ b/R/correctSettings.R
@@ -11,8 +11,6 @@ correctSettings <- function(result) {
   # check input
   result <- omopgenerics::validateResultArgument(result)
 
-  if (nrow(result) == 0) return(result)
-
   set <- omopgenerics::settings(result)
 
   cols <- c("group", "strata", "additional")
diff --git a/tests/testthat/test-choices.R b/tests/testthat/test-choices.R
new file mode 100644
index 0000000..4d7791c
--- /dev/null
+++ b/tests/testthat/test-choices.R
@@ -0,0 +1,83 @@
+test_that("test getChoices", {
+  # empty result
+  res <- emptySummarisedResult()
+  expect_no_error(x <- getChoices(res))
+  expected <- list()
+  names(expected) <- character()
+  expect_identical(x, expected)
+
+  # check only settings
+  resT <- c("custom_result_1", "custom_result_2")
+  res <- emptySummarisedResult(settings = dplyr::tibble(
+    result_id = c(1L, 2L),
+    result_type = resT,
+    package_name = "omopViewer",
+    package_version = "1.0.0",
+    param = c(TRUE, NA),
+    x = c(0, 1)
+  ))
+  expect_no_error(x <- getChoices(res))
+  expect_true(all(sort(resT) == sort(names(x))))
+  # names
+  expect_identical(names(x$custom_result_1), c("settings", "grouping", "variable_name", "estimate_name", "tidy_columns"))
+  expect_identical(names(x$custom_result_2), c("settings", "grouping", "variable_name", "estimate_name", "tidy_columns"))
+  # tidy columns
+  expect_identical(x$custom_result_1$tidy_columns, c("cdm_name", "param", "x"))
+  expect_identical(x$custom_result_2$tidy_columns, c("cdm_name", "x"))
+  # settings
+  expect_identical(x$custom_result_1$settings$param, "TRUE")
+  expect_identical(x$custom_result_1$settings$x, "0")
+  expect_false("param" %in% names(x$custom_result_2$settings))
+  expect_identical(x$custom_result_2$settings$x, "1")
+
+  # a set of summarised_results
+  res <- omopgenerics::newSummarisedResult(
+    x = dplyr::tibble(
+      result_id = c(1L, 2L),
+      cdm_name = c("cdm1", "cdm2"),
+      group_name = "cohort_name",
+      group_level = "cohort_1",
+      strata_name = c("age &&& sex", "year"),
+      strata_level = c("<40 &&& F", "2010"),
+      variable_name = "number_subjects",
+      variable_level = NA_character_,
+      estimate_name = "count",
+      estimate_type = "integer",
+      estimate_value = "100",
+      additional_name = c("overall", "time"),
+      additional_level = c("overall", "1")
+    ),
+    settings = dplyr::tibble(
+      result_id = c(1L, 2L),
+      result_type = resT,
+      package_name = "omopViewer",
+      package_version = "1.0.0",
+      param = c(TRUE, NA),
+      x = c(0, 1)
+    )
+  )
+  expect_no_error(x <- getChoices(res))
+  expect_true(all(sort(resT) == sort(names(x))))
+  # names
+  expect_identical(names(x$custom_result_1), c("settings", "grouping", "variable_name", "estimate_name", "tidy_columns"))
+  expect_identical(names(x$custom_result_2), c("settings", "grouping", "variable_name", "estimate_name", "tidy_columns"))
+  # tidy columns
+  expect_identical(x$custom_result_1$tidy_columns, c("cdm_name", "cohort_name", "age", "sex", "param", "x"))
+  expect_identical(x$custom_result_2$tidy_columns, c("cdm_name", "cohort_name", "year", "time", "x"))
+  # settings
+  expect_identical(x$custom_result_1$settings$param, "TRUE")
+  expect_identical(x$custom_result_1$settings$x, "0")
+  expect_false("param" %in% names(x$custom_result_2$settings))
+  expect_identical(x$custom_result_2$settings$x, "1")
+  # grouping
+  expect_identical(names(x$custom_result_1$grouping), c("cdm_name", "cohort_name", "age", "sex"))
+  expect_identical(names(x$custom_result_2$grouping), c("cdm_name", "cohort_name", "year", "time"))
+  expect_identical(x$custom_result_1$grouping$cdm_name, "cdm1")
+  expect_identical(x$custom_result_1$grouping$cohort_name, "cohort_1")
+  expect_identical(x$custom_result_1$grouping$age, "<40")
+  expect_identical(x$custom_result_1$grouping$sex, "F")
+  expect_identical(x$custom_result_2$grouping$cdm_name, "cdm2")
+  expect_identical(x$custom_result_2$grouping$cohort_name, "cohort_1")
+  expect_identical(x$custom_result_2$grouping$year, "2010")
+  expect_identical(x$custom_result_2$grouping$time, "1")
+})
diff --git a/tests/testthat/test-correctSettings.R b/tests/testthat/test-correctSettings.R
index fcd5d6e..2647ec5 100644
--- a/tests/testthat/test-correctSettings.R
+++ b/tests/testthat/test-correctSettings.R
@@ -2,7 +2,17 @@ test_that("correctSettings columns", {
 
   # empty summarised_result
   expect_identical(
-    emptySummarisedResult(), emptySummarisedResult() |> correctSettings()
+    emptySummarisedResult(settings = dplyr::tibble(
+      result_id = integer(),
+      result_type = character(),
+      package_name = character(),
+      package_version = character(),
+      group = character(),
+      strata = character(),
+      additional = character()
+    )),
+    emptySummarisedResult() |>
+      correctSettings()
   )
 
   # simple example