Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Yarn Version Specifications Incorrect in README.md #4750

Open
batlasAEI opened this issue Jan 31, 2025 · 1 comment
Open

[Bug] Yarn Version Specifications Incorrect in README.md #4750

batlasAEI opened this issue Jan 31, 2025 · 1 comment
Labels
Awaiting Reproduction Can we reproduce the reported bug?

Comments

@batlasAEI
Copy link

batlasAEI commented Jan 31, 2025

Describe the Bug

The v3.9 release branch's monorepo root readme file is claiming yarn v1.17.3+, though the minimum dependencies described in the ohif-monorepo-root claim >=1.20.0.

- [Yarn 1.17.3+](https://yarnpkg.com/en/docs/install)

"yarn": ">=1.20.0"

Steps to Reproduce

  1. View README.md here:
    - [Yarn 1.17.3+](https://yarnpkg.com/en/docs/install)

The current behavior

v1.17.3+ listed in requirements. This will actually cause an incompatibility message to be thrown on yarn install if using 1.17.3.

$ yarn install
yarn install v1.17.3
$ node preinstall.js
preinstall.js
No GITHUB_TOKEN found, skipping private repo customization
[1/5] Validating package.json...
error ohif-monorepo-root@: The engine "yarn" is incompatible with this module. Expected version ">=1.20.0". Got "1.17.3"

The expected behavior

v1.20.0+ should be listed

OS

n/a

Node version

n/a

Browser

n/a

@batlasAEI batlasAEI added the Awaiting Reproduction Can we reproduce the reported bug? label Jan 31, 2025
Copy link
Member

sedghi commented Feb 4, 2025

can you make a PR for us to correct the docs? thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Reproduction Can we reproduce the reported bug?
Projects
None yet
Development

No branches or pull requests

2 participants