Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update map setting display #3856

Open
benfurber opened this issue Sep 19, 2024 · 1 comment · May be fixed by #3862
Open

feat: update map setting display #3856

benfurber opened this issue Sep 19, 2024 · 1 comment · May be fixed by #3862

Comments

@benfurber
Copy link
Member

benfurber commented Sep 19, 2024

Description

The setting to add/update a map pin (at /settings/map) does it's thing but more context could be given to the user so they understand how their info will be displayed on the map.

Design requirements and description by @dalibormrska

The design proposal for now is this. First of all, the user would have the style of the pin based on the type of profile they have.

The preview of the card would be done just as it would be on the real map. The pin would be always in the open state and draggable. On click we would want to move the pin to the bottom of the map container so that both the pin and the card would be visible. I thought this would save space, layout decisions and introducing another element into the pool. In this way we would just utilise the existing elements.

image

Make sure that the height of the map is enough for the card of a space profile to show.

Build suggestion

While the necessary user data will need to be passed through to MapWithPin on SettingsPageMapPin, hopefully MapPin (packages/components/src/MapWithPin/MapPin.tsx) is the only component that needs much work. And what needs implementing is probably very close to what's used on Clusters (src/pages/Maps/Content/MapView/Cluster.tsx) with the Popup component.

As MapPin is in the component library already (which is what we want), moving Popup (src/pages/Maps/Content/MapView/Popup.tsx) to the component library too would be the best path forward.

@LahuenGR
Copy link

LahuenGR commented Sep 25, 2024

Hi guys, I'm working on this request. What do you think about this?

2024-09-25 04_04_20-Window

Using the current Popup configuration. I think that, if you want something that resembles that design, we should adjust that component directly.

Edit: I also removed the one-click functionality to move the pin, as it was not working well with the click-n-popup idea. Now you have to double click to move the pin (or drag)

LahuenGR pushed a commit to LahuenGR/community-platform that referenced this issue Sep 25, 2024
Pin is now like the Map page and, when clicked, displays the popup

fix ONEARMY#3856
@LahuenGR LahuenGR linked a pull request Sep 25, 2024 that will close this issue
12 tasks
LahuenGR pushed a commit to LahuenGR/community-platform that referenced this issue Sep 25, 2024
Pin is now like the Map page and, when clicked, displays the popup

fix ONEARMY#3856
LahuenGR pushed a commit to LahuenGR/community-platform that referenced this issue Sep 25, 2024
Pin is now like the Map page and, when clicked, displays the popup

fix ONEARMY#3856
LahuenGR pushed a commit to LahuenGR/community-platform that referenced this issue Sep 25, 2024
Pin is now like the Map page and, when clicked, displays the popup

fix ONEARMY#3856
LahuenGR pushed a commit to LahuenGR/community-platform that referenced this issue Sep 25, 2024
Pin is now like the Map page and, when clicked, displays the popup

fix ONEARMY#3856
LahuenGR pushed a commit to LahuenGR/community-platform that referenced this issue Sep 25, 2024
Pin is now like the Map page and, when clicked, displays the popup

fix ONEARMY#3856
LahuenGR pushed a commit to LahuenGR/community-platform that referenced this issue Sep 26, 2024
Pin is now like the Map page and, when clicked, displays the popup

fix ONEARMY#3856
LahuenGR pushed a commit to LahuenGR/community-platform that referenced this issue Sep 26, 2024
Pin is now like the Map page and, when clicked, displays the popup

fix ONEARMY#3856
LahuenGR pushed a commit to LahuenGR/community-platform that referenced this issue Sep 26, 2024
Pin is now like the Map page and, when clicked, displays the popup

fix ONEARMY#3856
LahuenGR pushed a commit to LahuenGR/community-platform that referenced this issue Sep 26, 2024
Pin is now like the Map page and, when clicked, displays the popup

fix ONEARMY#3856
LahuenGR pushed a commit to LahuenGR/community-platform that referenced this issue Sep 26, 2024
Pin is now like the Map page and, when clicked, displays the popup

fix ONEARMY#3856
LahuenGR pushed a commit to LahuenGR/community-platform that referenced this issue Sep 26, 2024
Pin is now like the Map page and, when clicked, displays the popup

fix ONEARMY#3856
LahuenGR pushed a commit to LahuenGR/community-platform that referenced this issue Sep 26, 2024
Pin is now like the Map page and, when clicked, displays the popup

fix ONEARMY#3856
LahuenGR pushed a commit to LahuenGR/community-platform that referenced this issue Sep 26, 2024
Pin is now like the Map page and, when clicked, displays the popup

fix ONEARMY#3856
LahuenGR pushed a commit to LahuenGR/community-platform that referenced this issue Sep 26, 2024
Pin is now like the Map page and, when clicked, displays the popup

fix ONEARMY#3856
LahuenGR pushed a commit to LahuenGR/community-platform that referenced this issue Sep 26, 2024
Pin is now like the Map page and, when clicked, displays the popup

fix ONEARMY#3856
benfurber pushed a commit to LahuenGR/community-platform that referenced this issue Oct 8, 2024
Pin is now like the Map page and, when clicked, displays the popup

fix ONEARMY#3856
benfurber pushed a commit to LahuenGR/community-platform that referenced this issue Oct 8, 2024
Pin is now like the Map page and, when clicked, displays the popup

fix ONEARMY#3856
benfurber pushed a commit to LahuenGR/community-platform that referenced this issue Oct 8, 2024
Pin is now like the Map page and, when clicked, displays the popup

fix ONEARMY#3856
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: New / Under Discussion
Development

Successfully merging a pull request may close this issue.

2 participants