-
-
Notifications
You must be signed in to change notification settings - Fork 394
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add profile tags to all profile types #3908
Comments
Could we separate the implementation to members? As i think this is not fully thought out yet since they have quite different 'tags' from the space profiles |
@davehakkens Do you mean have a seperate list of tag options? |
Could be. But not sure if that is worth the added complexity at this point? What do you think? I do know that at minimum we needs tags for spaces Members is a nice to have |
@davehakkens As community and members don't have any custom fields atm it's super easy to add them. Can you please provide a list of labels for:
Happy receive 1, 2 and 3 whenever. Need all parts of 1 or 3 at the same time to make releasing simple. |
Sorry, @davehakkens I missed that the first setence was a question. I think it's worth doing all of this. I see the value from a product prospect, it's not that much more work to do it all and then the code is simplier at the end as we have one way of doing it all. |
@benfurber Why is PP Community (2) different from PK and FF Space (3), it would eventually all work the same right? |
@davehakkens Yes, all ProfileTypes on an instance use the same profile tags. But there are different tags for PK, PP and FF right? For 2 I mean the PP "COMMUNITY_BUILDER" profile type, it's coded differently to "SPACE". Should they be the same thing? |
Correct.
Strange, what is different between them? In my head that one was always the same as the others. Regarding the tag list. Here is a document |
Re. COMMUNITY_BUILDER versus SPACE. I'll remove the difference. Thanks for the doc. Super easy to change/extend in the future. Once the DB migration work is done, settings the tags will move to the DB anyway. |
Many elements of the Precious Plastic specific profile types (workspaces, machine shop, etc.) are highly specifc. This makes extension for other projects more complex.
The main is to remove all the space fields for the PP specific profile types and replace them with a more generic profile tags field which can then also be added to the member and space profile types.
To-do:
The text was updated successfully, but these errors were encountered: