Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add profile tags to all profile types #3908

Open
19 of 21 tasks
benfurber opened this issue Oct 18, 2024 · 9 comments
Open
19 of 21 tasks

feat: add profile tags to all profile types #3908

benfurber opened this issue Oct 18, 2024 · 9 comments
Assignees

Comments

@benfurber
Copy link
Member

benfurber commented Oct 18, 2024

Many elements of the Precious Plastic specific profile types (workspaces, machine shop, etc.) are highly specifc. This makes extension for other projects more complex.

The main is to remove all the space fields for the PP specific profile types and replace them with a more generic profile tags field which can then also be added to the member and space profile types.

To-do:

  • Add tags to typing
  • Add tags to the user update functions
  • Add tags to machine shops profiletype setting
  • Add tags to machine shops profile page
  • Update machine shop data on prod DB
  • Add tags to workspaces profiletype setting
  • Add tags to workspaces shops profile page
  • Update workspaces data on prod DB
  • Add tags to collection point profiletype setting
  • Add tags to collection point shops profile page
  • Update collection point data on prod DB
  • Add tags to community profiletype setting
  • Add tags to community profile page
  • Add tags to spaced profiletype setting
  • Add tags to spaced profile page
  • Update spaces tags data to theme level
  • Update member tags data to theme level
  • Add tags to member profiletype setting
  • Add tags to member profile page
  • Update design of select list field (for this field and other tag fields)
  • Add rule so that five really is the max number that can be selected
@davehakkens
Copy link
Contributor

davehakkens commented Oct 18, 2024

Could we separate the implementation to members?

As i think this is not fully thought out yet since they have quite different 'tags' from the space profiles

@benfurber
Copy link
Member Author

@davehakkens Do you mean have a seperate list of tag options?

@davehakkens
Copy link
Contributor

davehakkens commented Oct 18, 2024

@davehakkens Do you mean have a seperate list of tag options?

Could be. But not sure if that is worth the added complexity at this point? What do you think?

I do know that at minimum we needs tags for spaces

Members is a nice to have

@benfurber
Copy link
Member Author

@davehakkens As community and members don't have any custom fields atm it's super easy to add them.

Can you please provide a list of labels for:

  1. PP members, PK members and FF members.
  2. PP community.
  3. PK space and FF space.

Happy receive 1, 2 and 3 whenever. Need all parts of 1 or 3 at the same time to make releasing simple.

@benfurber
Copy link
Member Author

@davehakkens Do you mean have a seperate list of tag options?

Could be. But not sure if that is worth the added complexity at this point? What do you think?

I do know that at minimum we needs tags for spaces

Members is a nice to have

Sorry, @davehakkens I missed that the first setence was a question. I think it's worth doing all of this. I see the value from a product prospect, it's not that much more work to do it all and then the code is simplier at the end as we have one way of doing it all.

@davehakkens
Copy link
Contributor

@benfurber Why is PP Community (2) different from PK and FF Space (3), it would eventually all work the same right?
-> All spaces on an instance use the same profile-tags

@benfurber
Copy link
Member Author

@davehakkens Yes, all ProfileTypes on an instance use the same profile tags. But there are different tags for PK, PP and FF right?

For 2 I mean the PP "COMMUNITY_BUILDER" profile type, it's coded differently to "SPACE". Should they be the same thing?

@davehakkens
Copy link
Contributor

davehakkens commented Oct 24, 2024

@davehakkens Yes, all ProfileTypes on an instance use the same profile tags. But there are different tags for PK, PP and FF right?

Correct.

For 2 I mean the PP "COMMUNITY_BUILDER" profile type, it's coded differently to "SPACE". Should they be the same thing?

Strange, what is different between them? In my head that one was always the same as the others.

Regarding the tag list. Here is a document
It's not 100% thought out, as we would still need to do this work for PK somewhere in the winter.
But perhaps we could use it as a start and iterate as we go, or prefer to finalize first?

@benfurber
Copy link
Member Author

Re. COMMUNITY_BUILDER versus SPACE. I'll remove the difference.

Thanks for the doc. Super easy to change/extend in the future. Once the DB migration work is done, settings the tags will move to the DB anyway.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: New / Under Discussion
Development

No branches or pull requests

2 participants