-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Download from HumHub yields old version of document due to browser caching #28
Comments
@dreua, please specify some additional information about your environment and the issue:
Please note that you need to wait about 15-20 seconds after the browser tab with file is closed, as there is a file conversion and save delay. |
Hey @alexanderonlyoffice, thanks for your reply! Were you not able to reproduce the issue or haven't you tried yet? It seems to me that this is a caching issue that would need to be fixed in humhub or the onlyoffice-humhub plugin, the document server is not really involved in that imho. I forgot to mention that I instantly get the newest version when I download with a different browser (one that hasn't downloaded that document before) and I do not see a request in the Apache access log whenever I get an old version of a file, therefore I think it must be the browser cache. To your requests for more information:
I gave it a few minutes but still get the same old version in the same browser. I think I once got a version that was older than a day. |
@dreua, we checked the case and we also encountered the problem with caching. The reason of the problem is in implementation of caching in HumHub and it cannot be solved on the connector's side. We would recommend you to try to contact HumHub team regarding this issue. Temporary solution would be to disable cache in HumHub or to download the files from the editor directly: File tab -> Download as... option. |
@alexanderonlyoffice Thank you for your investigation and clarification! |
Fix confirmed with 1.8.1, closing. Thanks to everyone involved! ❤️ |
Steps to reproduce
Expected Results
Downloaded file has the latest changes.
Actual Results
When using HTTPS or Chromium browser: Downloaded file is outdated, the same as in in step 1.
Tested browsers
Chromium 85.0.4183.102 (Developer Build): Issue appears via both HTTP and HTTPS
Firefox 81.0: Issue appears via HTTPS. On HTTP only the very last change may be missing if you download right after closing the editor. After navigation in HumHub or page reload, you get the latest version. (My best guess is that HTTPS enables the progressive web app which in turn changes something in the caching.)
(Both running on Linux / Fedora 32)
Further information
If you slightly change the download url (right click on Download button-> copy url) e.g. the argument download=0 to download=1 or any other value, you get the latest version.
Example: https://my-server/index.php?r=file%2Ffile%2Fdownload&guid=b7a22780-9a71-471e-b9ae-ab7a55a9951a&download=12345
Downloading from within onlyoffice (i.e. "Edit Document”, top left “File” -> “Download as”) also works correctly but I must assume it is rarely used compared to direct download from humhub.
Questions
Versions
Server: CentOS 8, DocumentServer in Docker container accessible through an Apache reverse proxy for SSL. Same Apache serves HumHub on a different subdomain.
Humhub 1.7.1
ONLYOFFICE Connector for HumHub 2.1.4
The text was updated successfully, but these errors were encountered: