Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Il8n support for 'Select Path' #4174

Closed
matthewabrown opened this issue Feb 19, 2025 · 2 comments · Fixed by #4176
Closed

Il8n support for 'Select Path' #4174

matthewabrown opened this issue Feb 19, 2025 · 2 comments · Fixed by #4176
Milestone

Comments

@matthewabrown
Copy link

<button type="button" class="btn btn-primary" id="<%= button_id %>">Select Path</button>

The current text is "Select Path", but this seems non-standard to me. We're customizing for our site, but I would suggest that "Browse..." is a more universally understandable text for this button, at least from my experience/ecosystems.

Thank you for the continual updates, features, and improvements!

@osc-bot osc-bot added this to the Backlog milestone Feb 19, 2025
@johrstrom johrstrom modified the milestones: Backlog, 4.0 Feb 19, 2025
@johrstrom
Copy link
Contributor

🤦‍♂ These 2 entries are not internationalizable. I'll put this into 4.0 and try to get it back ported for you to change to anything you like.

<button type="button" class="btn btn-primary" id="<%= button_id %>">Select Path</button>

@johrstrom johrstrom changed the title Change button text to more common "Browse..." Il8n support for 'Select Path' Feb 19, 2025
@matthewabrown
Copy link
Author

Sure, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants