Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review and update content about SameSite cookies #1005

Open
rbsec opened this issue Dec 27, 2022 · 3 comments
Open

Review and update content about SameSite cookies #1005

rbsec opened this issue Dec 27, 2022 · 3 comments
Assignees
Labels
revise Needs quality review, updates, or revision

Comments

@rbsec
Copy link
Collaborator

rbsec commented Dec 27, 2022

There are few areas of the guide that don't really take into account the current state of SameSite cookies:

  • The Testing Cookie Attributes guide says that "most" browsers" default to Lax, but this isn't true for Firefox or Safari.
  • The Cross-Site Request Forgery guide doesn't mention it at all, and the PoCs given won't work in some browsers because of it.
  • The Cross-Site Script Inclusion guide doesn't mention it at all, and the PoC given won't work in some (all? Inappropriate content (Testing for Cross Site Script Inclusion) #954) browsers because of it.

There might also be some other areas that I've missed?

@rbsec rbsec added help wanted revise Needs quality review, updates, or revision labels Dec 27, 2022
@mademarc
Copy link

Hey @rbsec Can in contribute and help out on this issue that needs revise?

Please let know when possible

@kingthorin
Copy link
Collaborator

Absolutely. Just let us know if you have questions or if there's enough detail there to get you started.

@mademarc
Copy link

Thanks @kingthorin and i just message you some questions via slack, did you received them?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
revise Needs quality review, updates, or revision
Projects
None yet
Development

No branches or pull requests

3 participants