-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Possible error in 4.4.6 Testing for Browser Cache Weaknesses #1077
Comments
@kingthorin what do you think? Testing between cache and history is a slightly tricky game, should we partially merge the section and recommendations? |
Hey @aBUDmdBQ how can i help and contribute to resolve this issue? please let me know and thanks |
The best first step would be to read the comments here and see if you agree with @ThunderSon's suggestion (he's one of the project leads 😉). |
Hey @kingthorin Yes i have read the CONTRIBUTING.md and Yeah i also agree with @ThunderSon as i have some points to help out, should i post them here on the comment section? |
Here is good, then everyone can collaborate and land in the right place/plan. |
Hey you all, Right now I do not have the opportunity to test this. But if I get to test it soon, I will add my findings here. |
What's the issue?
In 4.4.6 Testing for Browser Cache Weaknesses in the paragraph Browser History it says:
"The Back button can be stopped from showing sensitive data. This can be done by:
"
In a recent penetration test I had the issue that by using the back button after logging out I could retrieve the information previously shown again. I then modified the headers in the response to see if the advise from above works. At least in Firefox it did not, for other browsers I did not test it. After setting Cache-Control: must-revalidate the information could still be retrieved in the described way.
How do we solve it?
According to https://stackoverflow.com/questions/49547/how-do-we-control-web-page-caching-across-all-browsers the correct setting for the headers are:
Cache-Control: no-cache, no-store, must-revalidate
Pragma: no-cache
Expires: 0
At least in my tests I could confirm that these headers resolved the issue.
Would you like to be assigned to this issue?
Check the box if you will submit a PR to fix this issue. Please read CONTRIBUTING.md.
The text was updated successfully, but these errors were encountered: