Support for specifying taints for a MachinePool | Adding a NOTE about…

… MachinePool labels Signed-off-by: Archisman <[email protected]>
Obmondo · Sep 18, 2024 · def0201 · def0201
1 parent 6e665b3
commit def0201
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 5 deletions.
diff --git a/argocd-helm-charts/capi-cluster/charts/aws/templates/KubeadmConfig.yaml b/argocd-helm-charts/capi-cluster/charts/aws/templates/KubeadmConfig.yaml
@@ -11,5 +11,8 @@ spec:
       kubeletExtraArgs:
         cloud-provider: external
       name: '{{"{{"}} ds.meta_data.local_hostname {{"}}"}}'
+      {{- if $machinePool.taints }}
+      taints: {{- toYaml $machinePool.taints | nindent 8 }}
+      {{- end }}
 {{- end }}
 {{- end }}
diff --git a/argocd-helm-charts/capi-cluster/charts/aws/templates/MachinePool.yaml b/argocd-helm-charts/capi-cluster/charts/aws/templates/MachinePool.yaml
@@ -9,12 +9,17 @@ spec:
   clusterName: {{ $.Values.global.clusterName }}
   replicas: {{ $machinePool.replicas }}
   template:
+    {{- if $machinePool.labels }}
     metadata:
-      labels:
-        machine-pool: {{ printf "%s-%s" $.Values.global.clusterName $machinePool.name }}
-        {{- if $machinePool.labels }}
-        {{- toYaml $machinePool.labels | nindent 8 }}
-        {{- end }}
+      # Label should meet one of the following criterias to propagate to Node :
+      #
+      # (1) Has node-role.kubernetes.io as prefix.
+      # (2) Belongs to node-restriction.kubernetes.io domain.
+      # (3) Belongs to node.cluster.x-k8s.io domain.
+      #
+      # REFER : https://cluster-api.sigs.k8s.io/developer/architecture/controllers/metadata-propagation#machine
+      labels: {{- toYaml $machinePool.labels | nindent 8 }}
+    {{- end }}
     spec:
       bootstrap:
         configRef: