Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update eady.jl #136

Merged
merged 3 commits into from
Aug 29, 2023
Merged

Update eady.jl #136

merged 3 commits into from
Aug 29, 2023

Conversation

johnryantaylor
Copy link
Collaborator

reduced initial timestep to 1 minute in Eady.jl to be more conservative and avoid CFL violation on finer grids

reduced initial timestep to 1 minute in Eady.jl to be more conservative and avoid CFL violation on finer grids
@codecov
Copy link

codecov bot commented Aug 28, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (21fb27c) 63.82% compared to head (1f87d4d) 63.82%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #136   +/-   ##
=======================================
  Coverage   63.82%   63.82%           
=======================================
  Files          28       28           
  Lines        1020     1020           
=======================================
  Hits          651      651           
  Misses        369      369           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jagoosw
Copy link
Collaborator

jagoosw commented Aug 29, 2023

Could we do:

v₀ = V(0, 0, 0, 0, background_state_parameters)

Δx = minimum_xspacing(grid, Center(), Center(), Center())
Δy = minimum_yspacing(grid, Center(), Center(), Center())
Δz = minimum_zspacing(grid, Center(), Center(), Center())

Δt₀ = 0.75 * min(Δx, Δy, Δz) / v₀

simulation = Simulation(model, Δt = Δt₀, stop_time = 10days)

so that it is setup right whatever grid size someone uses?

@johnryantaylor
Copy link
Collaborator Author

johnryantaylor commented Aug 29, 2023 via email

examples/eady.jl Outdated Show resolved Hide resolved
@jagoosw jagoosw merged commit ef69e24 into main Aug 29, 2023
4 checks passed
@jagoosw jagoosw deleted the johnryantaylor-patch-1 branch August 29, 2023 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants