diff --git a/OctopusDSC/DSCResources/cOctopusServer/cOctopusServer.psm1 b/OctopusDSC/DSCResources/cOctopusServer/cOctopusServer.psm1 index 4fa3f1101..1a17558e9 100644 --- a/OctopusDSC/DSCResources/cOctopusServer/cOctopusServer.psm1 +++ b/OctopusDSC/DSCResources/cOctopusServer/cOctopusServer.psm1 @@ -334,7 +334,7 @@ function Test-OctopusVersionRequiresDatabaseBeforeConfigure { } function Test-OctopusVersionSupportsTaskMetricsLogging { - return Test-OctopusVersionNewerThan (New-Object System.Version 2018, 2, 7) + return (Test-OctopusVersionNewerThan (New-Object System.Version 2018, 2, 7)) -and (-not (Test-OctopusVersionNewerThan (New-Object System.Version 2020, 5, 0))) } function Test-OctopusVersionSupportsTaskCap { @@ -686,7 +686,7 @@ function Set-OctopusDeployConfiguration { } if ((-not (Test-OctopusVersionSupportsTaskMetricsLogging)) -and $logTaskMetrics) { - throw "LogTaskMetrics = 'true' is only supported from Octopus 2018.2.7" + throw "LogTaskMetrics = 'true' is only supported from Octopus 2018.2.7, and was removed in 2020.5.0" } if ( diff --git a/OctopusDSC/Tests/OctopusServerExeInvocationFiles/ChangeWebListenPrefix/CurrentState.ps1 b/OctopusDSC/Tests/OctopusServerExeInvocationFiles/ChangeWebListenPrefix/CurrentState.ps1 index 2a5544447..8234453f2 100644 --- a/OctopusDSC/Tests/OctopusServerExeInvocationFiles/ChangeWebListenPrefix/CurrentState.ps1 +++ b/OctopusDSC/Tests/OctopusServerExeInvocationFiles/ChangeWebListenPrefix/CurrentState.ps1 @@ -20,6 +20,4 @@ return @{ ArtifactsDirectory = "C:\Octopus\Artifacts"; AutoLoginEnabled = $true LicenseKey = "PExpY2Vuc2UgU2lnbmF0dXJlPSJoUE5sNFJvYWx2T2wveXNUdC9Rak4xcC9PeVVQc0l6b0FJS282bk9VM1kzMUg4OHlqaUI2cDZGeFVDWEV4dEttdWhWV3hVSTR4S3dJcU9vMTMyVE1FUT09Ij4gICA8TGljZW5zZWRUbz5PY3RvVGVzdCBDb21wYW55PC9MaWNlbnNlZFRvPiAgIDxMaWNlbnNlS2V5PjI0NDE0LTQ4ODUyLTE1NDI3LTQxMDgyPC9MaWNlbnNlS2V5PiAgIDxWZXJzaW9uPjIuMDwhLS0gTGljZW5zZSBTY2hlbWEgVmVyc2lvbiAtLT48L1ZlcnNpb24+ICAgPFZhbGlkRnJvbT4yMDE3LTEyLTA4PC9WYWxpZEZyb20+ICAgPE1haW50ZW5hbmNlRXhwaXJlcz4yMDIzLTAxLTAxPC9NYWludGVuYW5jZUV4cGlyZXM+ICAgPFByb2plY3RMaW1pdD5VbmxpbWl0ZWQ8L1Byb2plY3RMaW1pdD4gICA8TWFjaGluZUxpbWl0PjE8L01hY2hpbmVMaW1pdD4gICA8VXNlckxpbWl0PlVubGltaXRlZDwvVXNlckxpbWl0PiA8L0xpY2Vuc2U+" - LogTaskMetrics=$true; - LogRequestMetrics=$true; } diff --git a/OctopusDSC/Tests/OctopusServerExeInvocationFiles/ChangeWebListenPrefix/RequestedState.ps1 b/OctopusDSC/Tests/OctopusServerExeInvocationFiles/ChangeWebListenPrefix/RequestedState.ps1 index cbbc0469e..4bb21955d 100644 --- a/OctopusDSC/Tests/OctopusServerExeInvocationFiles/ChangeWebListenPrefix/RequestedState.ps1 +++ b/OctopusDSC/Tests/OctopusServerExeInvocationFiles/ChangeWebListenPrefix/RequestedState.ps1 @@ -16,6 +16,4 @@ return @{ HomeDirectory = "C:\Octopus"; AutoLoginEnabled = $true LicenseKey = "PExpY2Vuc2UgU2lnbmF0dXJlPSJoUE5sNFJvYWx2T2wveXNUdC9Rak4xcC9PeVVQc0l6b0FJS282bk9VM1kzMUg4OHlqaUI2cDZGeFVDWEV4dEttdWhWV3hVSTR4S3dJcU9vMTMyVE1FUT09Ij4gICA8TGljZW5zZWRUbz5PY3RvVGVzdCBDb21wYW55PC9MaWNlbnNlZFRvPiAgIDxMaWNlbnNlS2V5PjI0NDE0LTQ4ODUyLTE1NDI3LTQxMDgyPC9MaWNlbnNlS2V5PiAgIDxWZXJzaW9uPjIuMDwhLS0gTGljZW5zZSBTY2hlbWEgVmVyc2lvbiAtLT48L1ZlcnNpb24+ICAgPFZhbGlkRnJvbT4yMDE3LTEyLTA4PC9WYWxpZEZyb20+ICAgPE1haW50ZW5hbmNlRXhwaXJlcz4yMDIzLTAxLTAxPC9NYWludGVuYW5jZUV4cGlyZXM+ICAgPFByb2plY3RMaW1pdD5VbmxpbWl0ZWQ8L1Byb2plY3RMaW1pdD4gICA8TWFjaGluZUxpbWl0PjE8L01hY2hpbmVMaW1pdD4gICA8VXNlckxpbWl0PlVubGltaXRlZDwvVXNlckxpbWl0PiA8L0xpY2Vuc2U+" - LogTaskMetrics=$true; - LogRequestMetrics=$true; } diff --git a/OctopusDSC/Tests/OctopusServerExeInvocationFiles/NewInstanceWithMetrics/ExpectedResult.ps1 b/OctopusDSC/Tests/OctopusServerExeInvocationFiles/NewInstanceWithMetrics/ExpectedResult.ps1 index 0fdec5452..df44a8ca9 100644 --- a/OctopusDSC/Tests/OctopusServerExeInvocationFiles/NewInstanceWithMetrics/ExpectedResult.ps1 +++ b/OctopusDSC/Tests/OctopusServerExeInvocationFiles/NewInstanceWithMetrics/ExpectedResult.ps1 @@ -6,7 +6,6 @@ return @( "admin --console --instance OctopusServer --username Admin --password S3cur3P4ssphraseHere!", "license --console --instance OctopusServer --free", "path --console --instance OctopusServer --nugetRepository C:\Octopus\Packages --artifacts C:\Octopus\Artifacts --taskLogs C:\Octopus\TaskLogs", - "metrics --console --instance OctopusServer --tasks True --webapi True" "service --console --instance OctopusServer --install --reconfigure --stop", "service --start --console --instance OctopusServer" ) diff --git a/OctopusDSC/Tests/OctopusServerExeInvocationFiles/NewInstanceWithMetrics/RequestedState.ps1 b/OctopusDSC/Tests/OctopusServerExeInvocationFiles/NewInstanceWithMetrics/RequestedState.ps1 index 404d606fd..4b78b105a 100644 --- a/OctopusDSC/Tests/OctopusServerExeInvocationFiles/NewInstanceWithMetrics/RequestedState.ps1 +++ b/OctopusDSC/Tests/OctopusServerExeInvocationFiles/NewInstanceWithMetrics/RequestedState.ps1 @@ -14,6 +14,4 @@ return @{ ListenPort = 10935; AllowCollectionOfUsageStatistics = $false; HomeDirectory = "C:\Octopus"; - LogRequestMetrics = $true - LogTaskMetrics = $true } diff --git a/OctopusDSC/Tests/OctopusServerExeInvocationFiles/UpgradeExistingInstance/CurrentState.ps1 b/OctopusDSC/Tests/OctopusServerExeInvocationFiles/UpgradeExistingInstance/CurrentState.ps1 index 6a898a339..6b7cdf794 100644 --- a/OctopusDSC/Tests/OctopusServerExeInvocationFiles/UpgradeExistingInstance/CurrentState.ps1 +++ b/OctopusDSC/Tests/OctopusServerExeInvocationFiles/UpgradeExistingInstance/CurrentState.ps1 @@ -23,7 +23,5 @@ return @{ ArtifactsDirectory = "C:\Octopus\Artifacts"; AutoLoginEnabled = $true LicenseKey = "PExpY2Vuc2UgU2lnbmF0dXJlPSJoUE5sNFJvYWx2T2wveXNUdC9Rak4xcC9PeVVQc0l6b0FJS282bk9VM1kzMUg4OHlqaUI2cDZGeFVDWEV4dEttdWhWV3hVSTR4S3dJcU9vMTMyVE1FUT09Ij4gICA8TGljZW5zZWRUbz5PY3RvVGVzdCBDb21wYW55PC9MaWNlbnNlZFRvPiAgIDxMaWNlbnNlS2V5PjI0NDE0LTQ4ODUyLTE1NDI3LTQxMDgyPC9MaWNlbnNlS2V5PiAgIDxWZXJzaW9uPjIuMDwhLS0gTGljZW5zZSBTY2hlbWEgVmVyc2lvbiAtLT48L1ZlcnNpb24+ICAgPFZhbGlkRnJvbT4yMDE3LTEyLTA4PC9WYWxpZEZyb20+ICAgPE1haW50ZW5hbmNlRXhwaXJlcz4yMDIzLTAxLTAxPC9NYWludGVuYW5jZUV4cGlyZXM+ICAgPFByb2plY3RMaW1pdD5VbmxpbWl0ZWQ8L1Byb2plY3RMaW1pdD4gICA8TWFjaGluZUxpbWl0PjE8L01hY2hpbmVMaW1pdD4gICA8VXNlckxpbWl0PlVubGltaXRlZDwvVXNlckxpbWl0PiA8L0xpY2Vuc2U+" - LogTaskMetrics=$false; - LogRequestMetrics=$false; SkipLicenseCheck = $true; -} \ No newline at end of file +} diff --git a/OctopusDSC/Tests/OctopusServerExeInvocationFiles/UpgradeExistingInstance/ExpectedResult.ps1 b/OctopusDSC/Tests/OctopusServerExeInvocationFiles/UpgradeExistingInstance/ExpectedResult.ps1 index e00a37eec..4378fc0f0 100644 --- a/OctopusDSC/Tests/OctopusServerExeInvocationFiles/UpgradeExistingInstance/ExpectedResult.ps1 +++ b/OctopusDSC/Tests/OctopusServerExeInvocationFiles/UpgradeExistingInstance/ExpectedResult.ps1 @@ -1,7 +1,6 @@ return @( "service --stop --console --instance OctopusServer", "configure --console --instance OctopusServer --upgradeCheck True --upgradeCheckWithStatistics False --webForceSSL False --webListenPrefixes http://localhost:82 --commsListenPort 10935 --home C:\Octopus --autoLoginEnabled True --hstsEnabled False --hstsMaxAge 3600", - "metrics --console --instance OctopusServer --tasks True --webapi True", "node --console --instance OctopusServer --taskCap 10", "database --upgrade --instance OctopusServer --skipLicenseCheck", "service --start --console --instance OctopusServer" diff --git a/OctopusDSC/Tests/OctopusServerExeInvocationFiles/UpgradeExistingInstance/RequestedState.ps1 b/OctopusDSC/Tests/OctopusServerExeInvocationFiles/UpgradeExistingInstance/RequestedState.ps1 index b83f045f0..d7bdae524 100644 --- a/OctopusDSC/Tests/OctopusServerExeInvocationFiles/UpgradeExistingInstance/RequestedState.ps1 +++ b/OctopusDSC/Tests/OctopusServerExeInvocationFiles/UpgradeExistingInstance/RequestedState.ps1 @@ -16,8 +16,6 @@ return @{ HomeDirectory = "C:\Octopus"; AutoLoginEnabled = $true LicenseKey = "PExpY2Vuc2UgU2lnbmF0dXJlPSJoUE5sNFJvYWx2T2wveXNUdC9Rak4xcC9PeVVQc0l6b0FJS282bk9VM1kzMUg4OHlqaUI2cDZGeFVDWEV4dEttdWhWV3hVSTR4S3dJcU9vMTMyVE1FUT09Ij4gICA8TGljZW5zZWRUbz5PY3RvVGVzdCBDb21wYW55PC9MaWNlbnNlZFRvPiAgIDxMaWNlbnNlS2V5PjI0NDE0LTQ4ODUyLTE1NDI3LTQxMDgyPC9MaWNlbnNlS2V5PiAgIDxWZXJzaW9uPjIuMDwhLS0gTGljZW5zZSBTY2hlbWEgVmVyc2lvbiAtLT48L1ZlcnNpb24+ICAgPFZhbGlkRnJvbT4yMDE3LTEyLTA4PC9WYWxpZEZyb20+ICAgPE1haW50ZW5hbmNlRXhwaXJlcz4yMDIzLTAxLTAxPC9NYWludGVuYW5jZUV4cGlyZXM+ICAgPFByb2plY3RMaW1pdD5VbmxpbWl0ZWQ8L1Byb2plY3RMaW1pdD4gICA8TWFjaGluZUxpbWl0PjE8L01hY2hpbmVMaW1pdD4gICA8VXNlckxpbWl0PlVubGltaXRlZDwvVXNlckxpbWl0PiA8L0xpY2Vuc2U+" - LogTaskMetrics=$true; - LogRequestMetrics=$true; SkipLicenseCheck = $true; TaskCap = 10; } diff --git a/OctopusDSC/Tests/OctopusServerExeInvocationFiles/WhenNothingChanges/CurrentState.ps1 b/OctopusDSC/Tests/OctopusServerExeInvocationFiles/WhenNothingChanges/CurrentState.ps1 index 590cf6754..d9de91aaa 100644 --- a/OctopusDSC/Tests/OctopusServerExeInvocationFiles/WhenNothingChanges/CurrentState.ps1 +++ b/OctopusDSC/Tests/OctopusServerExeInvocationFiles/WhenNothingChanges/CurrentState.ps1 @@ -25,8 +25,6 @@ return @{ ArtifactsDirectory = "C:\Octopus\Artifacts"; AutoLoginEnabled = $true LicenseKey = "PExpY2Vuc2UgU2lnbmF0dXJlPSJoUE5sNFJvYWx2T2wveXNUdC9Rak4xcC9PeVVQc0l6b0FJS282bk9VM1kzMUg4OHlqaUI2cDZGeFVDWEV4dEttdWhWV3hVSTR4S3dJcU9vMTMyVE1FUT09Ij4gICA8TGljZW5zZWRUbz5PY3RvVGVzdCBDb21wYW55PC9MaWNlbnNlZFRvPiAgIDxMaWNlbnNlS2V5PjI0NDE0LTQ4ODUyLTE1NDI3LTQxMDgyPC9MaWNlbnNlS2V5PiAgIDxWZXJzaW9uPjIuMDwhLS0gTGljZW5zZSBTY2hlbWEgVmVyc2lvbiAtLT48L1ZlcnNpb24+ICAgPFZhbGlkRnJvbT4yMDE3LTEyLTA4PC9WYWxpZEZyb20+ICAgPE1haW50ZW5hbmNlRXhwaXJlcz4yMDIzLTAxLTAxPC9NYWludGVuYW5jZUV4cGlyZXM+ICAgPFByb2plY3RMaW1pdD5VbmxpbWl0ZWQ8L1Byb2plY3RMaW1pdD4gICA8TWFjaGluZUxpbWl0PjE8L01hY2hpbmVMaW1pdD4gICA8VXNlckxpbWl0PlVubGltaXRlZDwvVXNlckxpbWl0PiA8L0xpY2Vuc2U+" - LogTaskMetrics=$true; - LogRequestMetrics=$true; OctopusMasterKey = $MasterKeyCred; ForceSSL = $true; OctopusBuiltInWorkerCredential = $octopusBuiltInWorkerCredential; diff --git a/OctopusDSC/Tests/OctopusServerExeInvocationFiles/WhenNothingChanges/RequestedState.ps1 b/OctopusDSC/Tests/OctopusServerExeInvocationFiles/WhenNothingChanges/RequestedState.ps1 index 154be5dd7..3bbca7333 100644 --- a/OctopusDSC/Tests/OctopusServerExeInvocationFiles/WhenNothingChanges/RequestedState.ps1 +++ b/OctopusDSC/Tests/OctopusServerExeInvocationFiles/WhenNothingChanges/RequestedState.ps1 @@ -21,8 +21,6 @@ return @{ HomeDirectory = "C:\Octopus"; AutoLoginEnabled = $true LicenseKey = "PExpY2Vuc2UgU2lnbmF0dXJlPSJoUE5sNFJvYWx2T2wveXNUdC9Rak4xcC9PeVVQc0l6b0FJS282bk9VM1kzMUg4OHlqaUI2cDZGeFVDWEV4dEttdWhWV3hVSTR4S3dJcU9vMTMyVE1FUT09Ij4gICA8TGljZW5zZWRUbz5PY3RvVGVzdCBDb21wYW55PC9MaWNlbnNlZFRvPiAgIDxMaWNlbnNlS2V5PjI0NDE0LTQ4ODUyLTE1NDI3LTQxMDgyPC9MaWNlbnNlS2V5PiAgIDxWZXJzaW9uPjIuMDwhLS0gTGljZW5zZSBTY2hlbWEgVmVyc2lvbiAtLT48L1ZlcnNpb24+ICAgPFZhbGlkRnJvbT4yMDE3LTEyLTA4PC9WYWxpZEZyb20+ICAgPE1haW50ZW5hbmNlRXhwaXJlcz4yMDIzLTAxLTAxPC9NYWludGVuYW5jZUV4cGlyZXM+ICAgPFByb2plY3RMaW1pdD5VbmxpbWl0ZWQ8L1Byb2plY3RMaW1pdD4gICA8TWFjaGluZUxpbWl0PjE8L01hY2hpbmVMaW1pdD4gICA8VXNlckxpbWl0PlVubGltaXRlZDwvVXNlckxpbWl0PiA8L0xpY2Vuc2U+" - LogTaskMetrics=$true; - LogRequestMetrics=$true; OctopusMasterKey = $MasterKeyCred; ForceSSL = $true; OctopusBuiltInWorkerCredential = $octopusBuiltInWorkerCredential; diff --git a/README-cOctopusServer.md b/README-cOctopusServer.md index 2ee5f659c..2a142d632 100644 --- a/README-cOctopusServer.md +++ b/README-cOctopusServer.md @@ -61,9 +61,6 @@ Configuration SampleConfig # if not supplied, Octopus will use a free license LicenseKey = "base64encodedlicense" - # whether to log metrics - LogTaskMetrics = $false - LogRequestMetrics = $false TaskCap = 10 } @@ -124,8 +121,8 @@ When `State` is `Started`, the resource will ensure that the Octopus Servr windo | `GrantDatabasePermissions` | `boolean` | `$true` | Whether to grant `db_owner` permissions to the service account user (`$OctopusServiceCredential` user if supplied, or `NT AUTHORITY\System`) | | `OctopusMasterKey` | `PSCredential` | `[PSCredential]::Empty` | The master key for the existing database. | | `OctopusBuiltInWorkerCredential` | `PSCredential` | `[PSCredential]::Empty` | The user account to use to execute run-on-server scripts. If not supplied, executes scripts under the service account used for `Octopus.Server.exe` | -| `LogTaskMetrics` | `boolean` | `$false` | Whether to log task metrics | -| `LogRequestMetrics` | `boolean` | `$false` | Whether to log api requests metrics | +| `LogTaskMetrics` | `boolean` | `$false` | DEPRECATED. Whether to log task metrics | +| `LogRequestMetrics` | `boolean` | `$false` | DEPRECATED. Whether to log api requests metrics | | `TaskCap` | `int` | | The number of tasks this Octopus Server node should attempt to process at once | ## Drift diff --git a/Tests/Scenarios/Server_Scenario_01_Install.ps1 b/Tests/Scenarios/Server_Scenario_01_Install.ps1 index 2315e2bd9..fc41835bb 100644 --- a/Tests/Scenarios/Server_Scenario_01_Install.ps1 +++ b/Tests/Scenarios/Server_Scenario_01_Install.ps1 @@ -38,9 +38,6 @@ Configuration Server_Scenario_01_Install LicenseKey = "PExpY2Vuc2UgU2lnbmF0dXJlPSJoUE5sNFJvYWx2T2wveXNUdC9Rak4xcC9PeVVQc0l6b0FJS282bk9VM1kzMUg4OHlqaUI2cDZGeFVDWEV4dEttdWhWV3hVSTR4S3dJcU9vMTMyVE1FUT09Ij4gICA8TGljZW5zZWRUbz5PY3RvVGVzdCBDb21wYW55PC9MaWNlbnNlZFRvPiAgIDxMaWNlbnNlS2V5PjI0NDE0LTQ4ODUyLTE1NDI3LTQxMDgyPC9MaWNlbnNlS2V5PiAgIDxWZXJzaW9uPjIuMDwhLS0gTGljZW5zZSBTY2hlbWEgVmVyc2lvbiAtLT48L1ZlcnNpb24+ICAgPFZhbGlkRnJvbT4yMDE3LTEyLTA4PC9WYWxpZEZyb20+ICAgPE1haW50ZW5hbmNlRXhwaXJlcz4yMDIzLTAxLTAxPC9NYWludGVuYW5jZUV4cGlyZXM+ICAgPFByb2plY3RMaW1pdD5VbmxpbWl0ZWQ8L1Byb2plY3RMaW1pdD4gICA8TWFjaGluZUxpbWl0PjE8L01hY2hpbmVMaW1pdD4gICA8VXNlckxpbWl0PlVubGltaXRlZDwvVXNlckxpbWl0PiA8L0xpY2Vuc2U+" SkipLicenseCheck = $true - - LogTaskMetrics = $true - LogRequestMetrics = $false } cOctopusServerUsernamePasswordAuthentication "Enable Username/Password Auth" diff --git a/Tests/Spec/server_scenario_01_install_spec.rb b/Tests/Spec/server_scenario_01_install_spec.rb index 2dab47f55..d478c5a1a 100644 --- a/Tests/Spec/server_scenario_01_install_spec.rb +++ b/Tests/Spec/server_scenario_01_install_spec.rb @@ -16,10 +16,6 @@ it { should be_directory } end -describe file('c:/ChezOctopus/Logs/metrics.txt') do - it { should be_file } -end - describe file('c:/ChezOctopus/TaskLogs') do it { should be_directory } end