-
Notifications
You must be signed in to change notification settings - Fork 244
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Sample Onboard Request] meetings-live-code-interview #1117
Comments
Hi @Prithvi-MSFT, after a quick test, the sample doesn't work in my local machine. I also raise this as an issue in the origin repository. |
@JerryYangKai - Thanks for reporting the issue. Will check on the sample issue |
Hi @JerryYangKai - The issue is fixed and we have pushed the changes. Could you please verify once |
Hi @Prithvi-MSFT, thanks for your quick reply. |
@summzhan Sample test passed, please help review the doc part, |
README looks good to me. |
Onboarding PR: #1128 |
@tecton - By when will it be available in samples list ? |
Hi @Prithvi-MSFT, the sample is available in daily build version now. And it's expected to be released in next TTK prerelease version (next month). |
Hello @Prithvi-MSFT ! |
@JerryYangKai @Prithvi-MSFT , What's the status of this sample? it's seems stucked by weeks. |
@JerryYangKai - Could you please guide me on the repro steps so I can create and test the issue ? |
You can check the issue I created above, it is about the readme rendering, not the code running issue. |
@JerryYangKai - In issue its mentioned its in internal preview. Could you please guide how can I test this ? As the readme seem to look correct in repository |
Now this version is released as preview version and can be repro. Step 2 find the sample in sample gallery Step 3 click the sample to see the readme, and the issue will come out |
Hi @JerryYangKai , |
Great! |
Owner:
Name - Prithvi / GitHub user name - Prithvi-MSFT
ID:
meetings-live-code-interview
Title:
meetings-live-code-interview
Description:
This sample demos live coding in a teams meeting stage using live share SDK. The tab is loaded as side panel which contains various coding questions.
Tags:
"JS", "Live Share SDK"
Time:
5 mins to run
Configuration:
Ready
Thumbnail:
https://github.com/OfficeDev/Microsoft-Teams-Samples/blob/main/samples/meetings-live-code-interview/nodejs/assets/thumbnail.png
(Optional) Demo GIF:
https://github.com/OfficeDev/Microsoft-Teams-Samples/blob/main/samples/meetings-live-code-interview/nodejs/assets/sampleDemo.gif
(Source code in this Repo) Source Code PR:
Code in another PR
(Source code NOT in this Repo) Sample URL:
https://github.com/OfficeDev/Microsoft-Teams-Samples/tree/main/samples/meetings-live-code-interview/nodejs
(Optional) Minimum Teams Toolkit Version:
Teams Toolkit version requirement to run the sample - minimum version
(Optional) Maximum Teams Toolkit Version:
Teams Toolkit version requirement to run the sample - maximum version
The text was updated successfully, but these errors were encountered: