You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
For files in spond and tests, CI isort run should now flag unsorted imports using black compatible profile, report the diffs, (which is key to troubleshooting), fail all builds and thus all required checks.
It should also match behaviour of isort . run locally for files in these folders.
However CI isort run does not look at files outside these folders (it's not clear whether it did before as config was broken), as I could not seem to get the same results as running isort . locally after several attempts - which would make it pretty difficult to write compatible code.
This may not be feasible to fully fix. I think the time is better spent on moving to ruff (https://docs.astral.sh/ruff/) which can replace isort and black (and is compatible with some caveats), and is well documented and supported.
To get CI isort to run OK on files outside spond and tests, would need to deal with 'missing imports' issues for example scripts, e.g. ics package not specified in requirements. See very old #79
PR #107 passed all CI checks including
isort
linting: https://github.com/Olen/Spond/actions/runs/9096951441Expected behaviour: flag unsorted imports, fail all builds and thus all required checks.
If I run
isort
on it locally, I get a number of issues:Should investigate and verify other checks are working OK.
The text was updated successfully, but these errors were encountered: