-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Thumbnail images don't work in OctoPrint 1.9 release candidates #214
Comments
+1 Flask has deprecated the See also: https://flask.palletsprojects.com/en/2.3.x/api/?highlight=send_file#flask.send_file Hopefully this will be removed soon. EDIT:
Change line 443 to this:
Be careful to not remove any whitespace before or after the line! Just remove the |
I can confirm @pandel 's solution above resolves the issue of thumbnails not showing up in Octoprint 1.9 (official release version for me) |
Not sure if this is still being maintained, but I created a PR to fix this PR: #216 |
@clarkiej strange, that must be something different. In my case, the fix did not interfere with new thumbnails, they appear just fine. |
One more happy user :) |
I have this exact same issue with OctoPrint 1.9.1 using the new camera stack. My camera stream and snapshot test work fine in the I applied the fix to make my old thumbnails display. All new jobs do not display the thumbnails. They do no not exist in the snapshots directory. Here is a log:
|
Very strange, now it is working correctly on the fourth print. I did not install any new plugins or reboot the system. It looks like the user changed from Here are updated logs with it working:
|
I've been having problems detecting thumbnails when printing was completed for a long time. While I find the decision not to allow the presence of special characters in the file name to be partially acceptable, I find the ban on the use of space unacceptable. |
After putting in this fix, I found that my history images are now upside down (flipped). I do have the setting for my camera set to flip horizontally and vertically so that they appear correctly when I monitor my camera. The new images stored and my history images are now upside down. |
FYI: The fix worked for me! |
I have the same issue, here's the logs from
|
Depending on your Python version you will have to change the path |
I'm told @OllisGit is back from a dev sabbatical so hopefully my PR will see some movement, along with other bugs. |
The OctoPi builds of OctoPrint 1.9 release candidates 1 through 5 all seem to cause problems for the thumbnail images in PrintJobHistory. All thumbnails show up as the broken link image. Rolling back to 1.8 stable fixes the problem
The text was updated successfully, but these errors were encountered: