Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependency on Microsoft.IdentityModel.Clients.ActiveDirectory <= 3.0 to latest version #40

Open
oatsoda opened this issue Feb 15, 2017 · 4 comments

Comments

@oatsoda
Copy link

oatsoda commented Feb 15, 2017

Currently limited to <= 3.0 but the latest version is 3.13.8

@adityanag
Copy link

I have the same issue. Trying to use this with my UWP app that also uses the UWP ToolKit.

Version conflict detected for Microsoft.IdentityModel.Clients.ActiveDirectory. 
 BookBoard (>= 1.0.0) -> Microsoft.Toolkit.Uwp.Services (>= 1.3.1) -> Microsoft.IdentityModel.Clients.ActiveDirectory (>= 3.13.7) 
 BookBoard (>= 1.0.0) -> Microsoft.OneDriveSDK.Authentication (>= 1.0.8) -> Microsoft.IdentityModel.Clients.ActiveDirectory (> 2.22.0 && < 3.0.0).

@23W
Copy link

23W commented Feb 20, 2017

I have similar issue. Why has dependency not been updated still?

@oatsoda
Copy link
Author

oatsoda commented Feb 20, 2017

I had a quick look to see if I could submit a pull request, but it looks like there are breaking changes (presumably this is why Microsoft.IdentityModel.Clients.ActiveDirectory moved to v3!).

The main one being that the AuthenticationResult no longer has properties called RefreshToken or IsMultipleResourceRefreshToken, which unfortunately looks like they have been wrapped. See https://github.com/OneDrive/onedrive-sdk-dotnet-msa-auth-adapter/blob/master/src/OneDrive.Sdk.Authentication.Common/Business/AuthenticationResultWrapper.cs#L89

@martinlaukkanen
Copy link

Please can the package at least be updated past 2.21.301221612 which is no longer available? 2.22 is the minimum available on nuget.

With 2.21 being referenced projects which cannot support assembly binding redirection cannot function! This include PowerShell modules where (any sane person) refuses to update system32 located .config files.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants