Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Secrets: failure in their evaluation #1811

Closed
well-it-wasnt-me opened this issue Jan 23, 2025 · 1 comment
Closed

Secrets: failure in their evaluation #1811

well-it-wasnt-me opened this issue Jan 23, 2025 · 1 comment
Labels
bug Something isn't working

Comments

@well-it-wasnt-me
Copy link

Describe the bug
If you use a secrets which string contains something that might remotely resemble Unicode the criteria script will fail

To Reproduce
Steps to reproduce the behavior:

  1. Go to secrets, add a random one
  2. As value for the string write '\u12kskfj'
  3. Go to monitor, criteria, edit
  4. A console log with the secret name is enough
  5. See error: Unicode error.

Note: casting doesn't work.

Expected behavior
Whatever is in the secret being treated as string.

Screenshots
n/a

Desktop (please complete the following information):

  • OS: all
  • Browser all
  • Version n/a

Smartphone (please complete the following information):

  • Device: all
  • OS: all
  • Browser all
  • Version n/a

Deployment Type
Is this issue on SaaS (at https://oneuptime.com) or self hosted (the version that you deployed on your server)?

Both

Additional context
Just write anything you wish as value for your secret as long it contains a backslash or a slash.

@well-it-wasnt-me well-it-wasnt-me added the bug Something isn't working label Jan 23, 2025
@simlarsen
Copy link
Contributor

Since this secrets is used in JavaScript. Please use \\u12kskfj instead

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants