Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ET "Blooming" Around water bodies #62

Closed
gabe-parrish opened this issue Mar 26, 2024 · 1 comment · Fixed by #63
Closed

Fix ET "Blooming" Around water bodies #62

gabe-parrish opened this issue Mar 26, 2024 · 1 comment · Fixed by #63
Assignees
Labels
enhancement New feature or request

Comments

@gabe-parrish
Copy link
Collaborator

Around water bodies, especially in deserts. We notice a halo of high ET around the entire water body. Gabriel Senay found a fix, which essentially amounts to commenting out this line:

.where(ndvi_avg_unmasked.lt(0), lst_avg_unmasked)

###Blooming Example
bloomed_ET

Fixed ET:

fixed_ET

@gabe-parrish gabe-parrish self-assigned this Mar 26, 2024
@gabe-parrish gabe-parrish added the enhancement New feature or request label Mar 26, 2024
@macfriedrichs
Copy link
Contributor

macfriedrichs commented Mar 26, 2024

One preferred solution to review - Replacing final .where statement for negative NDVI using lst_smooth_unmasked with Tc_warm100 derivative for the last Tc_cold layer condition as follows:

(Original) `var Tc_cold = lst_smooth_unmasked

    .where((ndvi_smooth.gte(0).and(ndvi_smooth.lte(ndvi_threshold))), Tc_warm)
    .where(ndvi_smooth.gt(ndvi_threshold), lst_smooth)
    .where(wet_region_mask_5km, Tc_warm100)
    .where(ndvi_smooth_unmasked.lt(0), lst_smooth_unmasked)`

with

(Fixed) `var Tc_cold = lst_smooth_unmasked

    .where((ndvi_smooth.gte(0).and(ndvi_smooth.lte(ndvi_threshold))), Tc_warm) 
    .where(ndvi_smooth.gt(ndvi_threshold), lst_smooth)
    .where(wet_region_mask_5km, Tc_warm100)
    .where(ndvi_smooth_unmasked.lt(0), Tc_warm100)`

@gabe-parrish gabe-parrish linked a pull request Mar 26, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants