-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Printing vote text in console? #23
Comments
It would make sense to log it. I believe that custom votes should be logged with its "votecommand" as key. Display command can be in the comment field. I would be against letting the engine intercept it. I am against any interference for old mods, as the cost is always too big. |
"Who" called a vote is already logged (but not which vote... that's the reason I opened this issue). Also what was the result (just as "passed" or "failed"... of course that may be improved by adding "yes w, no x, null y, required z" - z may vary if "light voting" dmflags is set). About listing the final vote of each player, I don't know if such info should be public (for completeness and transparency) or not (for privacy and not flooding console output... maybe a small delay between lines?)... |
I think that it should be possible to add the info in the same lines, to do not flood the console output (especially thinking about console feedback area in upper left corner). Note: maybe there is some better word than "null" to say who didn't vote at all, I don't know. |
In August, you implemented the "print in console what has been voted for" thing, thank you very much! |
Excuse me, looking at the code, I see there are different results strings: |
Hello.
When someone asks for a vote, it's possible to notice that the console doesn't show the text of the vote, hence it's not logged, while it may be an interesting info for admins managing servers (you cannot know what has been voted for, especially if the vote failed). What about adding it?
I don't know whether it would be a gamecode or engine thing, but I can guess the voting code should be in gamecode... (well, maybe one may "intercept" votes from engine to apply the change also to old mods, but probably that would be a more "hacky" thing, probably not worth it).
Note: in case of custom votes (http://openarena.wikia.com/wiki/Custom_votes), I don't know if it would be better to show "votecommand", "displayname" or "command" value, probably "displayname".
The text was updated successfully, but these errors were encountered: