Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lists feature: small UI bugs #2

Open
7 of 10 tasks
mushon opened this issue Dec 6, 2023 · 5 comments
Open
7 of 10 tasks

Lists feature: small UI bugs #2

mushon opened this issue Dec 6, 2023 · 5 comments
Assignees
@akariv
Labels
ui details Lists of small visual and interaction issues

Comments

@mushon
Copy link

mushon commented Dec 6, 2023 •
edited by akariv
Loading

  • icon should be filled as soon as it is clicked
  • all the card should be clickable (not only the title)
  • show pointer on hover (everywhere)
  • show remove from list icon when hovering on current list (image)
  • Add hover state to editable text
  • Update trash icon (should be larger)
  • Clicking the title of a list in the popup should open it in the sidebar
  • Clicking רשימה חדשה currently requires an extra click to edit. Make it take focus on the first click.
  • Missing the dropdown option in the list popup
  • Add tooltip to button (figma)
@mushon mushon added the ui details Lists of small visual and interaction issues label Dec 6, 2023
@akariv
Copy link
Member

akariv commented Dec 6, 2023 •
edited
Loading

show pointer on hover (everywhere)

I couldn't find where it doesn't show...

show remove from list icon when hovering on current list

Behavior in this case should be to remove from list and close the pop-up?

Clicking the title of a list in the popup should open it in the sidebar

  1. This is only in the list selection mode, correct?
  2. This also toggles the state of the subscription for that list - won't that be confusing?

Clicking רשימה חדשה currently requires an extra click to edit. Make it take focus on the first click.

I can't reproduce this. Which browser are you using? Can you share the reproduction steps?

@akariv akariv closed this as completed Dec 6, 2023
@akariv akariv reopened this Dec 6, 2023
@akariv
Copy link
Member

akariv commented Dec 6, 2023

@mushon a few questions above (make sure to open the issue cause I updated the comment).

I will fix all the rest.

akariv added a commit that referenced this issue Dec 6, 2023
@akariv
Fixes re #2
f3baac0
@mushon
Copy link
Author

mushon commented Dec 7, 2023

show pointer on hover (everywhere)

I couldn't find where it doesn't show...

  • all editable areas do not show pointer
  • username/image should take to all the lists by the user

show remove from list icon when hovering on current list

Behavior in this case should be to remove from list and close the pop-up?

yes

Clicking the title of a list in the popup should open it in the sidebar

  1. This is only in the list selection mode, correct?
  2. This also toggles the state of the subscription for that list - won't that be confusing?

You are right. Forget about it…

Clicking רשימה חדשה currently requires an extra click to edit. Make it take focus on the first click.

I can't reproduce this. Which browser are you using? Can you share the reproduction steps?

I'm using Brave, which should be the same as Chrome. I tried testing on Chrome too there's currently another bug that opens the page on every click on the card.

@akariv
Copy link
Member

akariv commented Dec 7, 2023

all editable areas do not show pointer

They show a 'text' cursor, as it's commonly expected on text editable areas

username/image should take to all the lists by the user

There's no such view at the moment, I agree that when the view exists it should link there.

yes

OK

You are right. Forget about it…

OK

opens the page on every click on the card

Which page and which card? Can you show me what you mean in Zoom?

akariv added a commit that referenced this issue Dec 7, 2023
@akariv
A different approach for making cards clickable (re #2)
87eac78
@akariv
Copy link
Member

akariv commented Dec 7, 2023

Which page and which card? Can you show me what you mean in Zoom?

nvm, I saw what you mean - it got in while fixing other things. Should be ok now.

akariv added a commit that referenced this issue Dec 28, 2023
@akariv
Adding lists (#5)
9039a51 
* ENV NODE_ENV=production

* Initial list-view and a bit of restructuring

* List view + list view edit + list view in app container

* Some style fixes, search results use routerlink

* More list view implementation

* Many fixes to the item addition flow

* More work on share dynamics

* Delete list and other small fixes

* less logs

* Fixes re #2

* A different approach for making cards clickable (re #2)

* Fixes for result card

* Different approach for positioning the dialog

* Modal layout

* Restore search result interaction

* Mobile layout fixes

* Share + more mobile tweaks

* visual qa

* Public lists

* Fix seo for lists page

* Restore main page tutorial

* Slightly improve the sharing interface + og image
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@akariv akariv

Labels
ui details Lists of small visual and interaction issues
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mushon @akariv