Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test go to definition of control variable of cilk_for loop #278

Merged
merged 1 commit into from
Oct 20, 2024

Conversation

VoxSciurorum
Copy link
Contributor

I was unable to make this test fail by backing out recent changes to clangd. The test program is

void f() {
  _Cilk_for(int ii = 99; ii < 999; ii += 1) { int jj = ii;};
}

and the definition to be looked up is ii.

@VoxSciurorum VoxSciurorum requested a review from neboat October 9, 2024 19:12
@neboat
Copy link
Collaborator

neboat commented Oct 17, 2024

Sorry, I made a mistake before when we talked about this. It looks like that go-to-definition is actually one of the few that does work without the recent clangd changes.

Here are some examples of other failures without those clangd changes:

image image

In contrast, these go-to-definitions work after the clangd changes:

image image

@VoxSciurorum
Copy link
Contributor Author

I updated the test to fail on dev/16.x and pass on dev/18.x.

@neboat neboat merged commit f78505e into dev/18.x Oct 20, 2024
2 checks passed
@VoxSciurorum VoxSciurorum deleted the jfc/cilk_for branch October 22, 2024 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants