Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DiagnosticPublisher attempts to use the main asyncio event loop from worker threads (which fails) #336

Open
pavel-kirienko opened this issue Apr 22, 2024 · 0 comments
Open

DiagnosticPublisher attempts to use the main asyncio event loop from worker threads (which fails) #336

pavel-kirienko opened this issue Apr 22, 2024 · 0 comments
Labels
class-defect domain-core help wanted severity-major

Comments

@pavel-kirienko
Copy link
Member

Here, the call to ensure_future is invalid because emit can be invoked from any thread while we must use the asyncio loop from the node thread:

pycyphal/pycyphal/application/diagnostic.py

Line 187 in 40e1482

self._fut = asyncio.ensure_future(self._publish(dcs_rec))

Related: #334
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
class-defect domain-core help wanted severity-major
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@pavel-kirienko