Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support multiple adaptors in CLI and worker #777

Closed
josephjclark opened this issue Sep 25, 2024 · 1 comment
Closed

Support multiple adaptors in CLI and worker #777

josephjclark opened this issue Sep 25, 2024 · 1 comment

Comments

@josephjclark
Copy link
Collaborator

The Collections API requires us to support multiple adaptors in the Worker (because we use an adaptor to provide the collections API).

The runtime and compiler should support multiple adaptors, they don't much care. And I think the CLI right now is cool with it.

Worker and Engine probably just assume a single adaptor.

So what I think we need to do is:

  • Lightning Runs can include an array of adaptors (although they won't, apart from unit tests)
  • ExecutionPlans should use an array of adaptors for each step (even if it's an array of 1)
  • Ensure that this all works OK
  • Ensure that the compiler can correctly generate imports with multiple adaptors (this could be a gotcha - didn't we switch off "smart imports"?)
  • Create multi-adaptor integration tests in CLI and Worker
@josephjclark
Copy link
Collaborator Author

Done in #801

@github-project-automation github-project-automation bot moved this from Backlog to Done in v2 Oct 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

No branches or pull requests

1 participant