Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Worker: support @local adaptor versions and load them from the monorepo #806

Open
josephjclark opened this issue Oct 23, 2024 · 1 comment · Fixed by #808
Open

Worker: support @local adaptor versions and load them from the monorepo #806

josephjclark opened this issue Oct 23, 2024 · 1 comment · Fixed by #808

Comments

@josephjclark
Copy link
Collaborator

The worker should support adaptor versions @local, as in, @openfn/language-common@local, in which case it should load the adaptor version from the monorepo rather than trying to install it.

The CLI works the same way when the -m or --use-monorepo flag is passed. It just bypasses autoinstallation.

In practice I think all this really means is passing the monorepo flag and path into the compiler and runtime - which are already monorepo aware.

@josephjclark
Copy link
Collaborator Author

There's a bit of a problem in the runtime associated with this

In the CLI, if you're running from the monorepo, then EVERYTHING runs from the monorepo

I'm not sure Lightning should work like that. It should only use the monorepo if you add @local explicitly.

Where this is a problem is that the current runtime design says: here's a map of module specifies and paths to load them from on disk. It's a global option.

What we really need to do is support this logic per step. Which means a runtime patch and a bunch of tests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: New Issues
Development

Successfully merging a pull request may close this issue.

1 participant