Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop bower support #850

Closed
manthey opened this issue Jun 15, 2018 · 2 comments
Closed

Drop bower support #850

manthey opened this issue Jun 15, 2018 · 2 comments

Comments

@manthey
Copy link
Contributor

manthey commented Jun 15, 2018

Bower has been deprecated since May, 2017. Based on this usage link, there aren't any bower packages that use geojs. As such, we should be able to remove support for bower without any problems. This involves removing bower.json. We also no longer need to include the build artifact geo.js in the root of the repository. Bower recommends incrementing the semver major version at the same time (since we are still version <1, this would actually be the minor version), though based on our lack of use, I don't think that is necessary.

Is there any reason to keep bower support?
@brianhelba
Copy link
Contributor

Fine with me now.

manthey added a commit that referenced this issue Jun 26, 2018
@manthey
Remove bower support.
54c8680 
This resolves issue #850.
@manthey manthey mentioned this issue Jun 26, 2018
Merged
@manthey
Copy link
Contributor Author

manthey commented Jul 12, 2018

Done in #856.

@manthey manthey closed this as completed Jul 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@brianhelba @manthey