Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

looseApplication has no effect #1841

Open
bmarwell opened this issue Oct 20, 2024 · 2 comments
Open

looseApplication has no effect #1841

bmarwell opened this issue Oct 20, 2024 · 2 comments

Comments

@bmarwell
Copy link
Contributor

Hi,

looseApplication seems broken. Although I set it to false, an XML file will be created when running mvn package liberty:dev.

https://github.com/OpenLiberty/ci.maven/blob/main/docs/deploy.md

Reproducer:

  • Create a multi-module-project
           <plugin>
                <groupId>io.openliberty.tools</groupId>
                <artifactId>liberty-maven-plugin</artifactId>
                <configuration>
                    <appsDirectory>apps</appsDirectory>
                    <looseApplication>false</looseApplication>
                    <stripVersion>true</stripVersion>
                    <userDirectory>${project.build.directory}/wlp-usr</userDirectory>
                    <outputDirectory>${project.build.directory}/wlp-out</outputDirectory>
                </configuration>
            </plugin>

There will be an xml in apps, not a war file.

@cherylking
Copy link
Member

@bmarwell dev mode requires loose application. You should see a log message indicating this. See this line of code. We do have some inconsistencies that were found recently though and are documented here.

@bmarwell
Copy link
Contributor Author

Thanks. I hadn't seen the actual warning, so please excuse this oversight.

I wanted to try a jar file, because Microsoft Playwright seems to have difficulties with wsjar: protocols, but luckily that can be disabled. However, it only runs on ubuntu...

Currently, I am trying to circumvent it by building my own Dockerfile, as there are no new ubuntu-jdk21+ OL images released, neither on DockerHub nor on icr.io (which can't be searched without an account).
Because of this, this issue can be considered low priority, at least for me.

Thanks for looking into it anyway!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants