-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate the loose application from WebSphere Liberty doc to OL.io doc #6852
Comments
6852-draft doc for loose applications #6852
Hi David @dmuelle A draft document has been added for loose applications: Please review the same. Regards, |
@ramkumar-k-9286 - some initial feedback-
I'll wait on further comments until we have dev review- |
one thing that is not clear is where the config file exists and what it's relationship to the server.xml is- how does the runtime find the loose app? |
6852-draft doc for loose applications-comm-inc-1 #6852
Hi Thomas @tbitonti A draft document has been added for loose applications: Please review the same and add the Please feel free to add comments here for changes that need to be made to the document. Regards, |
Review comments received on slack: Review notes:"It enables development tools ..." "provide the XML file to the runtime" Should "when you run the server package command" be indented? Maybe drop the sentence "The server is not started at the time of packaging and has no way to access the needed variable information." That sentence may not be 100% accurate. The sentence that follows it is accurate. "The Open Liberty server uses the loose application configuration file to obtain the application content, rather than locating it from a root directory or single archive." "Using the appropriate XML, you can take the following actions:" "Map the root of the archive" Under "Loose application configuration file examples", I'd make a note to say that the application name is taken from the application location. Continuing the examples, Configured Application: Application configuration: Dropins application: Under "Virtual paths and file names": An example mapping a file or an archive to the root of the enclosing archive would be useful. (This structure is used in "Considerations for loose applications".) Something like: If you add file or dir elements to an archive, the name of the file or directory in the loose archive can be the root location, "/". For example, to use the contents of a folder as the contents of the virtual archive: To use the contents of a application archive as the contents of the virtual archive: |
6852-draft doc for loose applications-comm-inc-2 #6852
6852-draft doc for loose applications-comm-inc-2 #6852
6852-draft doc for loose applications-comm-inc-3 #6852
Additional comments received on SlackWould adding a sentence after "Normally .." be helpful? That would create a parallal to "Normally", adding balance to the paragraph: For "When you run the server package command", does this apply to both ways to provide the XML file? Having indentation groups the statement with "Using the application dropins folder". Maybe change: I'd change: |
6852-draft doc for loose applications-comm-inc-4 #6852
Hi Thomas @tbitonti The suggested comments have been incorporated. The draft document Link: https://docs-draft-openlibertyio.mqj6zf7jocq.us-south.codeengine.appdomain.cloud/docs/latest/loose-applications.html Please review the same and add the Please feel free to add comments here if you need me to make any changes to the document. Regards, |
6852-draft doc for loose applications-comm-inc-5 #6852
6852-draft doc for loose applications-comm-inc-6 #6852
6852-draft doc for loose applications-comm-inc-7 #6852
6852-draft doc for loose applications-comm-inc-8 #6852
Migrate the loose application from WebSphere Liberty doc to OL.io doc
The text was updated successfully, but these errors were encountered: