-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Review feedback #12
Comments
FYI, @gkwan-ibm. |
Rephrased to:
Rephrased to:
I rephrased the sentences to explain that this option is included if the user has a pre-existing service principal that they want to use. Also, I changed the green command box to a grey box.
I moved the viewing the registry password command to the same section that the password is needed.
Rephrased to:
Removed that sentence. |
Here are the changes: 8864246 |
|
Is this okay for calling out why a resource group is needed?
|
I will consider something like: A resource group is an Azure construct to manage a logical collection of resources for your cloud deployments on Azure. For this guide, you will create a new resource group to manage the resources you need for your Kubernetes deployment. |
Also, "To view the credentials of your AKS cluster:" doesn't seem to go with the output that we show following the command. May be we need to update this explanation of the command. |
"For instance, virtual machines, databases, and storage networks are types of resources that resource groups can be formed from." -- I find "can be formed from" odd. Can we rephrase?
"Resource groups are dedicated to container registries because the resources in these registries are used by several different hosts and their containers." -- I find the use of "dedicated" here odd and I don't quite understand what we are trying to say here. Can we rephrase too?
"Since your application involves a lower usage of storage and image throughput, you are using a Basic SKU, due to its cost-optimized solution." -- Use of "cost-optimized solution" is weird. I will simply say it's cheaper if not cheapest option.
"If you’re unfamiliar with Dockerfiles, check out the Using Docker containers to develop microservices guide." -- Should point to the Containerize guide instead.
az aks create
with service-principal and client-secret: Do we need copyable for the command provided? This is optional, right? Can we call out when or in what case someone will need to do this?"Replace [password] with the registry password that you viewed in the last section by running the az acr credential show -n guideRegistry command." -- I don't think it's the "last section"?
"Now that your container images are built, you can deploy them using a Kubernetes resource definition." -- We have done more than building our container images? The cluster is ready too?
"It is important to clean up your resources when you are finished with the guide so that you do not incur additional charges for ongoing service." -- What do we mean by "ongoing service"?
Should not have the Docker guide as a related guide.
Remember to update the front matter of README.adoc where necessary before publishing.
The text was updated successfully, but these errors were encountered: